[Intel-gfx] [PATCH v2 0/5] drm/i915: Rename functions to match their entry points

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Fri Jul 12 07:42:01 UTC 2019


Quoting Chris Wilson (2019-07-11 10:40:02)
> Quoting Janusz Krzysztofik (2019-07-11 08:31:52)
> > Need for this was identified while working on split of driver unbind
> > path into _remove() and _release() parts.  Consistency in function
> > naming has been recognized as helpful when trying to work out which
> > phase the code is in.
> > 
> > v2: * early_probe pairs better with late_release (Chris),
> >     * exclude patch 6/6 "drm/i915: Rename "inject_load_failure" module
> >       parameter" for now, it requires updates on user (IGT) side
> >     * rebase on top of "drm/i915: Drop extern qualifiers from header
> >       function prototypes"
> > 
> > Janusz Krzysztofik (5):
> >   drm/i915: Rename "_load"/"_unload" to match PCI entry points
> >   drm/i915: Replace "_load" with "_probe" consequently
> >   drm/i915: Propagate "_release" function name suffix down
> >   drm/i915: Propagate "_remove" function name suffix down
> >   drm/i915: Propagate "_probe" function name suffix down
> 
> I'm happy with the chosen names and my main concern is for improving
> consistency for ease of discoverability, so

Definitely a change for the better. Found one typo, otherwise all good
to go.

Regards, Joonas


More information about the Intel-gfx mailing list