[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for EHL port programming

Patchwork patchwork at emeril.freedesktop.org
Fri Jun 21 02:27:38 UTC 2019


== Series Details ==

Series: EHL port programming
URL   : https://patchwork.freedesktop.org/series/62492/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
e8826f32a876 drm/i915/icl: Drop port parameter to icl_get_combo_buf_trans()
-:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#10: 
References: 9659c1af451a ("drm/i915/icl: combo port vswing programming changes per BSPEC")

-:10: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 9659c1af451a ("drm/i915/icl: combo port vswing programming changes per BSPEC")'
#10: 
References: 9659c1af451a ("drm/i915/icl: combo port vswing programming changes per BSPEC")

total: 1 errors, 1 warnings, 0 checks, 36 lines checked
518c8457a26b drm/i915/ehl: Add third combo PHY offset
1b989ddfe119 drm/i915/ehl: Don't program PHY_MISC on EHL PHY C
10865d66217d drm/i915/gen11: Start distinguishing 'phy' from 'port'
-:148: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__phy' - possible side-effects?
#148: FILE: drivers/gpu/drm/i915/display/intel_combo_phy.c:9:
+#define for_each_combo_phy(__dev_priv, __phy) \
+	for ((__phy) = PHY_A; (__phy) < I915_MAX_PHYS; (__phy)++)	\
+		for_each_if(intel_phy_is_combo(__dev_priv, __phy))

-:155: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__phy' - possible side-effects?
#155: FILE: drivers/gpu/drm/i915/display/intel_combo_phy.c:13:
+#define for_each_combo_phy_reverse(__dev_priv, __phy) \
+	for ((__phy) = I915_MAX_PHYS; (__phy)-- > PHY_A;) \
+		for_each_if(intel_phy_is_combo(__dev_priv, __phy))

-:881: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'phy' - possible side-effects?
#881: FILE: drivers/gpu/drm/i915/i915_reg.h:9684:
+#define  DPCLKA_CFGCR0_DDI_CLK_OFF(phy)		(1 << ((phy) == PHY_F ? 23 : \
+						      (phy) + 10))

-:890: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'phy' - possible side-effects?
#890: FILE: drivers/gpu/drm/i915/i915_reg.h:9689:
+#define  DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy)	((phy) == PHY_F ? 21 : \
+						(phy) * 2)

total: 0 errors, 0 warnings, 4 checks, 769 lines checked
8d9e8e6a8ceb drm/i915/ehl: Enable DDI-D



More information about the Intel-gfx mailing list