[Intel-gfx] [PATCH 1/1] drm/i915: Fix memleak in runtime wakeref tracking

Chris Wilson chris at chris-wilson.co.uk
Thu Jun 27 14:53:29 UTC 2019


Quoting Mika Kuoppala (2019-06-27 15:44:38)
> If we untrack wakerefs, the actual count may reach zero.
> However the krealloced owners array is still there and
> needs to be taken care of. Free the owners unconditionally
> to fix the leak.

That is true.

> Fixes: dbf99c1f8c7e ("drm/i915: Force printing wakeref tacking during pm_cleanup")

However, the bug is mine
Fixes: bd780f37a361 ("drm/i915: Track all held rpm wakerefs")

> Reported-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
> Cc: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Imre Deak <imre.deak at intel.com>
> Signed-off-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list