[Intel-gfx] [PATCH 1/1] drm/i915: Fix memleak in runtime wakeref tracking

[Mika Kuoppala]

Chris Wilson <chris at chris-wilson.co.uk> writes:

> Quoting Mika Kuoppala (2019-06-27 15:44:38)
>> If we untrack wakerefs, the actual count may reach zero.
>> However the krealloced owners array is still there and
>> needs to be taken care of. Free the owners unconditionally
>> to fix the leak.
>
> That is true.
>
>> Fixes: dbf99c1f8c7e ("drm/i915: Force printing wakeref tacking during pm_cleanup")
>
> However, the bug is mine
> Fixes: bd780f37a361 ("drm/i915: Track all held rpm wakerefs")

Indeed. Apologies Imre!

I personally know the reviewer of the original patch
and will have a discussion.
-Mika

>
>> Reported-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
>> Cc: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
>> Cc: Chris Wilson <chris at chris-wilson.co.uk>
>> Cc: Imre Deak <imre.deak at intel.com>
>> Signed-off-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
> -Chris