[Intel-gfx] [PATCH] drm/i915/gt: Mention which device failed

[Imre Deak]

On Fri, Nov 15, 2019 at 03:11:43PM +0200, Imre Deak wrote:
> On Fri, Nov 15, 2019 at 12:23:43PM +0000, Chris Wilson wrote:
> > When telling the user that device power management is disabled, it is
> > helpful to say which device that was. At the same time, while it is a
> > mere inconvenience to the user, it is devastating to CI as this and
> > future tests may fail out of the blue.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> > Cc: Imre Deak <imre.deak at intel.com>
> 
> Reviewed-by: Imre Deak <imre.deak at intel.com>

Although we would need a way to test recovery - which we a have a
testcase for - so tainting for that case is not ok.

> 
> > ---
> >  drivers/gpu/drm/i915/gt/intel_rc6.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i915/gt/intel_rc6.c
> > index 602a02d01850..b56a903431b8 100644
> > --- a/drivers/gpu/drm/i915/gt/intel_rc6.c
> > +++ b/drivers/gpu/drm/i915/gt/intel_rc6.c
> > @@ -540,7 +540,9 @@ void intel_rc6_ctx_wa_check(struct intel_rc6 *rc6)
> >  	if (!intel_rc6_ctx_corrupted(rc6))
> >  		return;
> >  
> > -	DRM_NOTE("RC6 context corruption, disabling runtime power management\n");
> > +	dev_notice(i915->drm.dev,
> > +		   "RC6 context corruption, disabling runtime power management\n");
> > +	add_taint_for_CI(TAINT_WARN);
> >  
> >  	intel_rc6_disable(rc6);
> >  	rc6->ctx_corrupted = true;
> > -- 
> > 2.24.0
> > 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx