[Intel-gfx] [PATCH] drm/i915/gt: Mention which device failed

Chris Wilson chris at chris-wilson.co.uk
Fri Nov 15 13:22:04 UTC 2019


Quoting Imre Deak (2019-11-15 13:15:30)
> On Fri, Nov 15, 2019 at 03:11:43PM +0200, Imre Deak wrote:
> > On Fri, Nov 15, 2019 at 12:23:43PM +0000, Chris Wilson wrote:
> > > When telling the user that device power management is disabled, it is
> > > helpful to say which device that was. At the same time, while it is a
> > > mere inconvenience to the user, it is devastating to CI as this and
> > > future tests may fail out of the blue.
> > > 
> > > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > > Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> > > Cc: Imre Deak <imre.deak at intel.com>
> > 
> > Reviewed-by: Imre Deak <imre.deak at intel.com>
> 
> Although we would need a way to test recovery - which we a have a
> testcase for - so tainting for that case is not ok.

You put that test at the end of the queue. Fwiw, we don't seem to see
the corrupt state across a module reload; either that or I am blind.

We probably should add the register + known state to the error dump.
-Chris


More information about the Intel-gfx mailing list