[Intel-gfx] [PATCH v2 2/2] drm/i915/dp: fix DP infoframe init for PORT_A on gen12+

Matt Roper matthew.d.roper at intel.com
Tue Nov 26 23:52:20 UTC 2019


On Mon, Nov 25, 2019 at 02:53:13PM +0200, Kai Vehmanen wrote:
> Starting with gen12, PORT_A can be also connected to DP
> transcoder. Update code in intel_dp_init() to take this
> into account.
> 
> Signed-off-by: Kai Vehmanen <kai.vehmanen at linux.intel.com>

I don't think this function gets called on gen12; this one is for
pre-DDI platforms.  DP initialization on recent platforms happens via
intel_ddi_init() and that one calls intel_infoframe_init without the
PORT_A restriction.


Matt

> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 4519c32f6c24..fd2b39fe0e60 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -7335,7 +7335,7 @@ bool intel_dp_init(struct drm_i915_private *dev_priv,
>  
>  	intel_dig_port->hpd_pulse = intel_dp_hpd_pulse;
>  
> -	if (port != PORT_A)
> +	if (port != PORT_A || INTEL_GEN(dev_priv) >=  12)
>  		intel_infoframe_init(intel_dig_port);
>  
>  	intel_dig_port->aux_ch = intel_bios_port_aux_ch(dev_priv, port);
> -- 
> 2.17.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795


More information about the Intel-gfx mailing list