[Intel-gfx] [PATCH v2 2/2] drm/i915/dp: fix DP infoframe init for PORT_A on gen12+

Kai Vehmanen kai.vehmanen at linux.intel.com
Thu Nov 28 15:09:37 UTC 2019


Hi,

On Tue, 26 Nov 2019, Matt Roper wrote:

> On Mon, Nov 25, 2019 at 02:53:13PM +0200, Kai Vehmanen wrote:
> > Starting with gen12, PORT_A can be also connected to DP
> > transcoder. Update code in intel_dp_init() to take this
> > into account.
> 
> I don't think this function gets called on gen12; this one is for
> pre-DDI platforms.  DP initialization on recent platforms happens via
> intel_ddi_init() and that one calls intel_infoframe_init without the
> PORT_A restriction.

aa, ok. Thanks for the reviews!

I was doing a mechanical check for all logic for PORT_A that assumed it 
cannot be connected to DP/HDMI, and didn't check the full call chain. But 
yeah, if this function never gets called on gen12, then this is a 
non-issue and patch an be dropped.

Br, Kai


More information about the Intel-gfx mailing list