[Intel-gfx] [PATCH] drm/i915/rps: Flip interpretation of ips fmin/fmax to max rps

Andi Shyti andi.shyti at intel.com
Sun Oct 27 19:01:33 UTC 2019


Hi Chris,

> diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c
> index 30f56c786468..032a0c6389f9 100644
> --- a/drivers/gpu/drm/i915/gt/intel_rps.c
> +++ b/drivers/gpu/drm/i915/gt/intel_rps.c
> @@ -180,8 +180,8 @@ static void gen5_rps_init(struct intel_rps *rps)
>  	DRM_DEBUG_DRIVER("fmax: %d, fmin: %d, fstart: %d\n",
>  			 fmax, fmin, fstart);
>  
> -	rps->min_freq = -fstart;

and we don't need fstart anymore... can we remove it?

Reviewed-by: Andi Shyti <andi.shyti at intel.com>

Andi

> -	rps->max_freq = -fmin;
> +	rps->min_freq = fmax;
> +	rps->max_freq = fmin;
>  
>  	rps->idle_freq = rps->min_freq;
>  	rps->cur_freq = rps->idle_freq;


More information about the Intel-gfx mailing list