[Intel-gfx] [PATCH] drm/i915/rps: Flip interpretation of ips fmin/fmax to max rps

[Chris Wilson]

Quoting Andi Shyti (2019-10-27 19:01:33)
> Hi Chris,
> 
> > diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c
> > index 30f56c786468..032a0c6389f9 100644
> > --- a/drivers/gpu/drm/i915/gt/intel_rps.c
> > +++ b/drivers/gpu/drm/i915/gt/intel_rps.c
> > @@ -180,8 +180,8 @@ static void gen5_rps_init(struct intel_rps *rps)
> >       DRM_DEBUG_DRIVER("fmax: %d, fmin: %d, fstart: %d\n",
> >                        fmax, fmin, fstart);
> >  
> > -     rps->min_freq = -fstart;
> 
> and we don't need fstart anymore... can we remove it?

I've not worked out how to best to use it, other than log it. The choice
is whether to restore to fstart on returning control to the BIOS (i.e.
module unload / intel_rps_disable) which is what we've previously tried.
But what's the point -- we use idle frequency currently, and so is
fstart a better choice for idle frequency (and would that be?) I have
more questions than answers, so left it alone.
-Chris