[Intel-gfx] [PATCH 2/3] drm/vkms: Use wait_for_flip_done

[Rodrigo Siqueira]

On 07/19, Daniel Vetter wrote:
> It's the recommended version, wait_for_vblanks is a bit a hacky
> interim thing that predates all the flip_done tracking. It's
> unfortunately still the default ...

Just one question, is it safe to replace drm_atomic_helper_wait_for_vblanks by
drm_atomic_helper_wait_for_flip_done? I noticed that only six drivers use these
functions; they are:

* atmel-hlcdc
* mediatek
* msm
* tegra
* tilcdc
* virtio

If we change these drivers, can we drop the helper
drm_atomic_helper_wait_for_vblanks?

Reviewed-by: Rodrigo Siqueira <rodrigosiqueiramelo at gmail.com>

Thanks

> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> Cc: Rodrigo Siqueira <rodrigosiqueiramelo at gmail.com>
> Cc: Haneen Mohammed <hamohammed.sa at gmail.com>
> Cc: Daniel Vetter <daniel at ffwll.ch>
> ---
>  drivers/gpu/drm/vkms/vkms_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> index 44ab9f8ef8be..80524a22412a 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.c
> +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> @@ -83,7 +83,7 @@ static void vkms_atomic_commit_tail(struct drm_atomic_state *old_state)
>  
>  	drm_atomic_helper_commit_hw_done(old_state);
>  
> -	drm_atomic_helper_wait_for_vblanks(dev, old_state);
> +	drm_atomic_helper_wait_for_flip_done(dev, old_state);
>  
>  	for_each_old_crtc_in_state(old_state, crtc, old_crtc_state, i) {
>  		struct vkms_crtc_state *vkms_state =
> -- 
> 2.22.0
> 

-- 
Rodrigo Siqueira
Software Engineer, Advanced Micro Devices (AMD)
https://siqueira.tech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20190903/f51c6171/attachment.sig>