[Intel-gfx] [PATCH 0/8] cdclk consolidation and rework for BXT-TGL

Matt Roper matthew.d.roper at intel.com
Sat Sep 7 00:21:35 UTC 2019


cdclk design hasn't changed much from BXT onward, but we still have
a lot of different codepaths to handle the different platforms and in
some cases they've evolved in different directions.  Let's try to
consolidate some of the common logic where it makes sense.

We also have some functions that are basically code repesentations of
tables in the bspec.  As new cdclk values get added/removed from the
bspec over time, or new platforms get enabled, it's easy to overlook
some of the places that we need to update various functions to reflect
those changes.  Let's try to address this by including a more literal
representation of the bspec tables in the driver and adapting our driver
to parse those tables to get the values they need.

Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>

Matt Roper (8):
  drm/i915: Consolidate bxt/cnl/icl cdclk readout
  drm/i915: Use literal representation of cdclk tables
  drm/i915: Combine bxt_set_cdclk and cnl_set_cdclk
  drm/i915: Kill cnl_sanitize_cdclk()
  drm/i915: Consolidate {bxt,cnl,icl}_uninit_cdclk
  drm/i915: Add calc_voltage_level display vfunc
  drm/i915: Enhance cdclk sanitization
  drm/i915: Consolidate {bxt,cnl,icl}_init_cdclk

 drivers/gpu/drm/i915/display/intel_cdclk.c | 977 ++++++++-------------
 drivers/gpu/drm/i915/display/intel_cdclk.h |   8 +
 drivers/gpu/drm/i915/i915_drv.h            |   5 +
 3 files changed, 358 insertions(+), 632 deletions(-)

-- 
2.20.1



More information about the Intel-gfx mailing list