[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Vulkan performance query support (rev17)

Patchwork patchwork at emeril.freedesktop.org
Mon Sep 9 13:46:09 UTC 2019


== Series Details ==

Series: drm/i915: Vulkan performance query support (rev17)
URL   : https://patchwork.freedesktop.org/series/60916/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
f668eec43e67 drm/i915: introduce a mechanism to extend execbuf2
-:141: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#141: FILE: include/uapi/drm/i915_drm.h:1165:
+#define __I915_EXEC_UNKNOWN_FLAGS (-(I915_EXEC_USE_EXTENSIONS<<1))
                                                              ^

total: 0 errors, 0 warnings, 1 checks, 113 lines checked
01e462c1ffb7 drm/i915: add syncobj timeline support
-:25: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#25: 
    https://lists.freedesktop.org/archives/dri-devel/2019-August/229287.html

total: 0 errors, 1 warnings, 0 checks, 541 lines checked
4585dca189a7 drm/i915/perf: drop list of streams
b57c0c8e871e drm/i915/perf: store the associated engine of a stream
6ca796aee82c drm/i915/perf: introduce a versioning of the i915-perf uapi
907b2948cada drm/i915/perf: move perf types to their own header
-:342: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#342: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 647 lines checked
cac9acbbf105 drm/i915/perf: allow for CS OA configs to be created lazily
9151840280e8 drm/i915/perf: implement active wait for noa configurations
-:258: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#258: FILE: drivers/gpu/drm/i915/i915_perf.c:1783:
+		DIV64_U64_ROUND_UP(

-:283: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#283: FILE: drivers/gpu/drm/i915/i915_perf.c:1808:
+	batch = cs = i915_gem_object_pin_map(bo, I915_MAP_WB);

-:291: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#291: FILE: drivers/gpu/drm/i915/i915_perf.c:1816:
+		cs = save_restore_register(

-:295: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#295: FILE: drivers/gpu/drm/i915/i915_perf.c:1820:
+	cs = save_restore_register(

-:395: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#395: FILE: drivers/gpu/drm/i915/i915_perf.c:1920:
+		cs = save_restore_register(

-:399: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#399: FILE: drivers/gpu/drm/i915/i915_perf.c:1924:
+	cs = save_restore_register(

total: 0 errors, 0 warnings, 6 checks, 418 lines checked
cbc959b97634 drm/i915: add wait flags to i915_active_request_retire
83208e81f732 drm/i915/perf: execute OA configuration from command stream
-:68: CHECK:LINE_SPACING: Please don't use multiple blank lines
#68: FILE: drivers/gpu/drm/i915/i915_perf.c:1576:
+
+

total: 0 errors, 0 warnings, 1 checks, 311 lines checked
2efaf8d89c09 drm/i915: add a new perf configuration execbuf parameter
-:27: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#27: 
v7: Hold drm.struct_mutex when serializing the request with OA config (Chris)

-:67: CHECK:LINE_SPACING: Please don't use multiple blank lines
#67: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1161:
 
+

-:100: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#100: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1194:
+	err = i915_perf_get_oa_config_and_bo(

-:153: WARNING:LONG_LINE_COMMENT: line over 100 characters
#153: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2139:
+	err = i915_request_await_object(eb->request, eb->oa_vma->obj, false); /* await_resv already! */

total: 0 errors, 2 warnings, 2 checks, 273 lines checked
3aea377b5819 drm/i915/perf: allow holding preemption on filtered ctx
a30df8fa37a2 drm/i915: add support for perf configuration queries



More information about the Intel-gfx mailing list