[Intel-gfx] [PATCH v7] drm/i915/pmu: Use GT parked for estimating RC6 while asleep

Chris Wilson chris at chris-wilson.co.uk
Thu Sep 12 12:44:42 UTC 2019


Quoting Tvrtko Ursulin (2019-09-12 13:38:47)
> 
> On 12/09/2019 12:32, Chris Wilson wrote:
> > +     if (val)
> > +             /*
> > +              * If we are coming back from being runtime suspended we must
> > +              * be careful not to report a larger value than returned
> > +              * previously.
> > +              */
> 
> The comment is a bit dislocated from the logic so feels it would better 
> go into __pmu_update_rc6.
> 
> > +             val = __pmu_update_rc6(pmu, val);
> > +     else
> > +             /*
> > +              * We were runtime suspended.
> 
> s/were/are/, or maybe it is "think we are". :)

"We think we are" captures my anxiety.

Moving both into their respective routines.
-Chris


More information about the Intel-gfx mailing list