[Intel-gfx] [PATCH 2/4] drm/i915/tgl: s/ss/eu fuse reading support

[Tvrtko Ursulin]

On 12/09/2019 16:35, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-09-12 16:18:08)
>>
>> On 12/09/2019 14:38, Mika Kuoppala wrote:
>>> diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
>>> index 469dc512cca3..30c542144016 100644
>>> --- a/include/uapi/drm/i915_drm.h
>>> +++ b/include/uapi/drm/i915_drm.h
>>> @@ -2033,8 +2033,10 @@ struct drm_i915_query {
>>>     *           (data[X / 8] >> (X % 8)) & 1
>>>     *
>>>     * - the subslice mask for each slice with one bit per subslice telling
>>> - *   whether a subslice is available. The availability of subslice Y in slice
>>> - *   X can be queried with the following formula :
>>> + *   whether a subslice is available. Gen12 has dual-subslices, which are
>>> + *   similar to two gen11 subslices. For gen12, this array represents dual-
>>
>> It's ugly in user facing documentation if we cannot decide whether it is
>> Gen12 or gen12. Gen12 special case also probably warrants to be in its
>> own paragraph.
> 
> Here it was using sentence capitalisation, which suits it if we are
> treating it as an ordinary noun. If went with a proper noun, then Gen12
> throughout. I might be wrong, but my impression is that we've
> historically used ordinary nouns (gen5-8, gen11, etc).

My bad.

Regards,

Tvrtko