[Intel-gfx] [PATCH 6/6] drm/i915/tgl: Add Clear Color supoort for TGL Render Decompression

[Jordan Justen]

On 2019-09-17 05:11:55, Radhakrishna Sripada wrote:
>                 return PLANE_CTL_TILED_Y | PLANE_CTL_RENDER_DECOMPRESSION_ENABLE;
>         case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS:
>                 return PLANE_CTL_TILED_Y | PLANE_CTL_MEDIA_DECOMPRESSION_ENABLE;
> @@ -9897,9 +9924,13 @@ skylake_get_initial_plane_config(struct intel_crtc *crtc,
>         case PLANE_CTL_TILED_Y:
>                 plane_config->tiling = I915_TILING_Y;
>                 if (val & PLANE_CTL_RENDER_DECOMPRESSION_ENABLE)

Should {} be added to this `if` since a nested if-else is being added?

> -                       fb->modifier = INTEL_GEN(dev_priv) >= 12 ?
> -                               I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS :
> -                               I915_FORMAT_MOD_Y_TILED_CCS;
> +                       if (INTEL_GEN(dev_priv) >= 12)
> +                               fb->modifier = val &
> +                                       ICL_PLANE_CTL_CLEAR_COLOR_DISABLE ?
> +                                       I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS :
> +                                       I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC;
> +                       else
> +                               fb->modifier = I915_FORMAT_MOD_Y_TILED_CCS;
>                 else if (val & PLANE_CTL_RENDER_DECOMPRESSION_ENABLE)
>                         fb->modifier = I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS;
>                 else