[Intel-gfx] [PATCH xf86-video-intel 11/21] sna: Increase the size of the path name buffer a bit

Ville Syrjala ville.syrjala at linux.intel.com
Thu Sep 19 16:31:03 UTC 2019


From: Ville Syrjälä <ville.syrjala at linux.intel.com>

../src/intel_device.c: In function ‘__intel_open_device__pci.isra.6’:
../src/intel_device.c:321:25: warning: ‘%s’ directive writing up to 255 bytes into a region of size 247 [-Wformat-overflow=]
   sprintf(path + base, "%s", de->d_name);

Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
---
 src/intel_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/intel_device.c b/src/intel_device.c
index 219550731500..f28d3be11796 100644
--- a/src/intel_device.c
+++ b/src/intel_device.c
@@ -301,9 +301,9 @@ static int open_cloexec(const char *path)
 #ifdef __linux__
 static int __intel_open_device__major_minor(int _major, int _minor)
 {
-	char path[256];
 	DIR *dir;
 	struct dirent *de;
+	char path[9+sizeof(de->d_name)];
 	int base, fd = -1;
 
 	base = sprintf(path, "/dev/dri/");
-- 
2.21.0



More information about the Intel-gfx mailing list