[Intel-gfx] [drm-intel:drm-intel-next-queued 5/7] drivers/gpu/drm/i915/display/intel_color.c:1535 i9xx_read_lut_8() error: potential null dereference 'blob'. (drm_property_create_blob returns null)
kbuild test robot
lkp at intel.com
Fri Sep 20 04:12:40 UTC 2019
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next-queued
head: 4bb6a9d5d9a8289673c4cb0786d44be8a63c21db
commit: 1af22383829864299102ca0c2eab458f755a9971 [5/7] drm/i915/display: Extract i9xx_read_luts()
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp at intel.com>
smatch warnings:
drivers/gpu/drm/i915/display/intel_color.c:1535 i9xx_read_lut_8() error: potential null dereference 'blob'. (drm_property_create_blob returns null)
vim +/blob +1535 drivers/gpu/drm/i915/display/intel_color.c
1518
1519 static struct drm_property_blob *
1520 i9xx_read_lut_8(const struct intel_crtc_state *crtc_state)
1521 {
1522 struct intel_crtc *crtc = to_intel_crtc(crtc_state->base.crtc);
1523 struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
1524 enum pipe pipe = crtc->pipe;
1525 struct drm_property_blob *blob;
1526 struct drm_color_lut *blob_data;
1527 u32 i, val;
1528
1529 blob = drm_property_create_blob(&dev_priv->drm,
1530 sizeof(struct drm_color_lut) * LEGACY_LUT_LENGTH,
1531 NULL);
1532 if (IS_ERR(blob))
1533 return NULL;
1534
> 1535 blob_data = blob->data;
1536
1537 for (i = 0; i < LEGACY_LUT_LENGTH; i++) {
1538 if (HAS_GMCH(dev_priv))
1539 val = I915_READ(PALETTE(pipe, i));
1540 else
1541 val = I915_READ(LGC_PALETTE(pipe, i));
1542
1543 blob_data[i].red = intel_color_lut_pack(REG_FIELD_GET(
1544 LGC_PALETTE_RED_MASK, val), 8);
1545 blob_data[i].green = intel_color_lut_pack(REG_FIELD_GET(
1546 LGC_PALETTE_GREEN_MASK, val), 8);
1547 blob_data[i].blue = intel_color_lut_pack(REG_FIELD_GET(
1548 LGC_PALETTE_BLUE_MASK, val), 8);
1549 }
1550
1551 return blob;
1552 }
1553
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
More information about the Intel-gfx
mailing list