[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for mdev based hardware virtio offloading support
Patchwork
patchwork at emeril.freedesktop.org
Fri Sep 20 12:10:47 UTC 2019
== Series Details ==
Series: mdev based hardware virtio offloading support
URL : https://patchwork.freedesktop.org/series/66989/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
32afcef2acff mdev: class id support
8efae9b60a78 mdev: introduce device specific ops
-:309: ERROR:CODE_INDENT: code indent should use tabs where possible
#309: FILE: include/linux/mdev.h:111:
+ const struct mdev_parent_ops *ops);$
-:309: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#309: FILE: include/linux/mdev.h:111:
+ const struct mdev_parent_ops *ops);$
-:314: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#314:
new file mode 100644
total: 1 errors, 2 warnings, 0 checks, 410 lines checked
7bbada3ad14d mdev: introduce virtio device and its device ops
-:50: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#50:
new file mode 100644
-:55: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#55: FILE: include/linux/virtio_mdev.h:1:
+/*
-:70: WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name
#70: FILE: include/linux/virtio_mdev.h:16:
+ irqreturn_t (*callback)(void *);
-:175: ERROR:CODE_INDENT: code indent should use tabs where possible
#175: FILE: include/linux/virtio_mdev.h:121:
+ /* Device ops */$
-:186: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#186: FILE: include/linux/virtio_mdev.h:132:
+ void (*get_config)(struct mdev_device *mdev, unsigned offset,
-:187: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#187: FILE: include/linux/virtio_mdev.h:133:
+ void *buf, unsigned len);
-:188: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#188: FILE: include/linux/virtio_mdev.h:134:
+ void (*set_config)(struct mdev_device *mdev, unsigned offset,
-:189: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#189: FILE: include/linux/virtio_mdev.h:135:
+ const void *buf, unsigned len);
total: 1 errors, 7 warnings, 0 checks, 168 lines checked
61e824bf250a virtio: introudce a mdev based transport
-:44: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#44:
new file mode 100644
-:84: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#84: FILE: drivers/vfio/mdev/virtio_mdev.c:36:
+ spinlock_t lock;
-:111: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#111: FILE: drivers/vfio/mdev/virtio_mdev.c:63:
+static void virtio_mdev_get(struct virtio_device *vdev, unsigned offset,
-:112: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#112: FILE: drivers/vfio/mdev/virtio_mdev.c:64:
+ void *buf, unsigned len)
-:120: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#120: FILE: drivers/vfio/mdev/virtio_mdev.c:72:
+static void virtio_mdev_set(struct virtio_device *vdev, unsigned offset,
-:121: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#121: FILE: drivers/vfio/mdev/virtio_mdev.c:73:
+ const void *buf, unsigned len)
-:189: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#189: FILE: drivers/vfio/mdev/virtio_mdev.c:141:
+virtio_mdev_setup_vq(struct virtio_device *vdev, unsigned index,
-:268: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#268: FILE: drivers/vfio/mdev/virtio_mdev.c:220:
+
+}
-:294: WARNING:RETURN_VOID: void function return statements are not generally useful
#294: FILE: drivers/vfio/mdev/virtio_mdev.c:246:
+ return;
+}
-:296: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#296: FILE: drivers/vfio/mdev/virtio_mdev.c:248:
+static int virtio_mdev_find_vqs(struct virtio_device *vdev, unsigned nvqs,
-:308: WARNING:LINE_SPACING: Missing a blank line after declarations
#308: FILE: drivers/vfio/mdev/virtio_mdev.c:260:
+ int i, err, queue_idx = 0;
+ vm_dev->vqs = kmalloc_array(queue_idx, sizeof(*vm_dev->vqs),
-:429: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#429: FILE: drivers/vfio/mdev/virtio_mdev.c:381:
+
+}
total: 0 errors, 9 warnings, 3 checks, 432 lines checked
17f868b5d9a4 vringh: fix copy direction of vringh_iov_push_kern()
822c68b1ca18 docs: Sample driver to demonstrate how to implement virtio-mdev framework
-:26: WARNING:CONFIG_DESCRIPTION: please write a paragraph that describes the config symbol fully
#26: FILE: samples/Kconfig:134:
+config SAMPLE_VIRTIO_MDEV_NET
-:46: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#46:
new file mode 100644
-:118: WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name
#118: FILE: samples/vfio-mdev/mvnet.c:68:
+ irqreturn_t (*cb)(void *);
-:127: ERROR:CODE_INDENT: code indent should use tabs where possible
#127: FILE: samples/vfio-mdev/mvnet.c:77:
+^I (1ULL << VIRTIO_F_VERSION_1) |$
-:128: WARNING:SPACING: space prohibited before semicolon
#128: FILE: samples/vfio-mdev/mvnet.c:78:
+ (1ULL << VIRTIO_F_IOMMU_PLATFORM) ;
-:134: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#134: FILE: samples/vfio-mdev/mvnet.c:84:
+ spinlock_t lock;
-:147: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#147: FILE: samples/vfio-mdev/mvnet.c:97:
+static void mvnet_queue_ready(struct mvnet_state *mvnet, unsigned idx)
-:167: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#167: FILE: samples/vfio-mdev/mvnet.c:117:
+ vringh_init_kern(&vq->vring, mvnet_features, MVNET_QUEUE_MAX,
+ false, 0, 0, 0);
-:232: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#232: FILE: samples/vfio-mdev/mvnet.c:182:
+ /* Make sure used is visible before rasing the
+ interrupt */
-:232: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#232: FILE: samples/vfio-mdev/mvnet.c:182:
+ interrupt */
-:265: WARNING:SPACING: space prohibited before semicolon
#265: FILE: samples/vfio-mdev/mvnet.c:215:
+ return ;
-:266: WARNING:RETURN_VOID: void function return statements are not generally useful
#266: FILE: samples/vfio-mdev/mvnet.c:216:
+ return ;
+}
-:274: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!addr"
#274: FILE: samples/vfio-mdev/mvnet.c:224:
+ if (addr == NULL)
-:277: CHECK:SPACING: No space is necessary after a cast
#277: FILE: samples/vfio-mdev/mvnet.c:227:
+ *dma_addr = (dma_addr_t) addr;
-:305: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*mvnet)...) over kzalloc(sizeof(struct mvnet_state)...)
#305: FILE: samples/vfio-mdev/mvnet.c:255:
+ mvnet = kzalloc(sizeof(struct mvnet_state), GFP_KERNEL);
-:306: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!mvnet"
#306: FILE: samples/vfio-mdev/mvnet.c:256:
+ if (mvnet == NULL)
-:360: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#360: FILE: samples/vfio-mdev/mvnet.c:310:
+sample_mvnet_dev_show(struct device *dev, struct device_attribute *attr,
+ char *buf)
-:608: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#608: FILE: samples/vfio-mdev/mvnet.c:558:
+static void mvnet_get_config(struct mdev_device *mdev, unsigned offset,
-:609: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#609: FILE: samples/vfio-mdev/mvnet.c:559:
+ void *buf, unsigned len)
-:617: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#617: FILE: samples/vfio-mdev/mvnet.c:567:
+static void mvnet_set_config(struct mdev_device *mdev, unsigned offset,
-:618: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#618: FILE: samples/vfio-mdev/mvnet.c:568:
+ const void *buf, unsigned len)
total: 1 errors, 13 warnings, 7 checks, 705 lines checked
More information about the Intel-gfx
mailing list