[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/23] drm/i915/dp: Fix dsc bpp calculations, v2.

Patchwork patchwork at emeril.freedesktop.org
Fri Sep 20 14:52:51 UTC 2019 

== Series Details ==

Series: series starting with [01/23] drm/i915/dp: Fix dsc bpp calculations, v2.
URL   : https://patchwork.freedesktop.org/series/66998/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
5a06a0350a83 drm/i915/dp: Fix dsc bpp calculations, v2.
30142b729b5c HAX drm/i915: Disable FEC entirely for now
-:14: WARNING:BAD_SIGN_OFF: 'Not-signed-off-by:' is the preferred signature form
#14: 
Not-Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>

-:40: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 1 warnings, 0 checks, 19 lines checked
2bb73b0ec47e drm/i915: Prepare to split crtc state in uapi and hw state
-:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#11: 
- crtc, *_changed flags, event, commit, state, mode_blob, (plane/connector/encoder)_mask.

-:2112: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#2112: FILE: drivers/gpu/drm/i915/display/intel_display.c:11201:
+	crtc_state->uapi.active = crtc_state->uapi.enable = true;

-:2810: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#2810: FILE: drivers/gpu/drm/i915/display/intel_display.c:16692:
+		crtc_state->hw.active = crtc_state->hw.enable =

-:3965: ERROR:CODE_INDENT: code indent should use tabs where possible
#3965: FILE: drivers/gpu/drm/i915/display/intel_sprite.c:211:
+^I^I^I^I          new_crtc_state->uapi.event);$

-:3965: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#3965: FILE: drivers/gpu/drm/i915/display/intel_sprite.c:211:
+		drm_crtc_arm_vblank_event(&crtc->base,
+				          new_crtc_state->uapi.event);

total: 1 errors, 1 warnings, 3 checks, 4348 lines checked
8fa117d4a277 drm/i915: Handle a few more cases for hw/sw split
fb10f9c4dae1 drm/i915: Complete sw/hw split
89bdbc955927 drm/i915: Get rid of crtc_state->fb_changed
1997dbaaa507 drm/i915: Remove begin/finish_crtc_commit.
35e0e945926a drm/i915: Rename planar linked plane variables
11b08875cb14 drm/i915: Do not add all planes when checking scalers on glk+
c5ac35a82acd drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid()
02ae546be7ff drm/i915: Try to make bigjoiner work in atomic check.
-:143: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#143: FILE: drivers/gpu/drm/i915/display/intel_display.c:11826:
+				intel_atomic_get_new_crtc_state(state,
+					crtc_state->bigjoiner_linked_crtc);

-:191: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#191: FILE: drivers/gpu/drm/i915/display/intel_display.c:12326:
+	crtc_state->nv12_planes = crtc_state->c8_planes = crtc_state->update_planes = 0;

-:217: WARNING:LONG_LINE: line over 100 characters
#217: FILE: drivers/gpu/drm/i915/display/intel_display.c:13625:
+	struct intel_crtc_state *old_crtc_state, *new_crtc_state, *slave_crtc_state, *master_crtc_state;

-:280: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#280: FILE: drivers/gpu/drm/i915/display/intel_display.c:13688:
+			slave = new_crtc_state->bigjoiner_linked_crtc =

-:290: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#290: FILE: drivers/gpu/drm/i915/display/intel_display.c:13698:
+				return -EINVAL;
+			} else {

-:348: ERROR:OPEN_BRACE: that open brace { should be on the previous line
#348: FILE: drivers/gpu/drm/i915/display/intel_display.c:13930:
+	if (new_crtc_state->bigjoiner)
+		{/* Not supported yet */}

total: 1 errors, 2 warnings, 3 checks, 391 lines checked
fe1d38cc6ac9 drm/i915: Enable big joiner support in enable and disable sequences.
-:121: WARNING:LONG_LINE_COMMENT: line over 100 characters
#121: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:4087:
+		 /* Our own transcoder needs to be disabled when reading it in intel_ddi_read_func_ctl() */

-:123: WARNING:LONG_LINE: line over 100 characters
#123: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:4089:
+		pipe_config->cpu_transcoder = (enum transcoder)pipe_config->bigjoiner_linked_crtc->pipe;

-:231: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#231: FILE: drivers/gpu/drm/i915/display/intel_display.c:6527:
+			I915_WRITE(PIPE_MULT(cpu_transcoder),
+				  pipe_config->pixel_multiplier - 1);

-:239: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#239: FILE: drivers/gpu/drm/i915/display/intel_display.c:6531:
+			intel_cpu_transcoder_set_m_n(pipe_config,
+						    &pipe_config->fdi_m_n, NULL);

-:348: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#348: FILE: drivers/gpu/drm/i915/display/intel_display.c:8353:
+		/*
+		  * transcoder is programmed to the full mode,

-:567: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#567: FILE: drivers/gpu/drm/i915/display/intel_display.c:13044:
+	if (!PIPE_CONF_QUIRK(PIPE_CONFIG_QUIRK_BIGJOINER_SLAVE)) {
 	PIPE_CONF_CHECK_X(dpll_hw_state.dpll);

-:776: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#776: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:789:
+#define PIPE_CONFIG_QUIRK_BIGJOINER_SLAVE	(1<<1) /* bigjoiner slave, partial readout */
                                          	  ^

total: 0 errors, 4 warnings, 3 checks, 934 lines checked
0334bd232823 drm/i915: Make hardware readout work on i915.
-:73: WARNING:LONG_LINE: line over 100 characters
#73: FILE: drivers/gpu/drm/i915/display/intel_display.c:10038:
+		    (I915_READ(PLANE_SURF(bigjoiner_pipe, plane_id)) & 0xfffff000) == plane_config->base) {

-:74: WARNING:LONG_LINE: line over 100 characters
#74: FILE: drivers/gpu/drm/i915/display/intel_display.c:10039:
+			val = I915_READ(PLANE_SIZE(crtc_state->bigjoiner_linked_crtc->pipe, plane_id));

-:109: WARNING:LONG_LINE: line over 100 characters
#109: FILE: drivers/gpu/drm/i915/display/intel_display.c:17173:
+				WARN_ON(drm_atomic_set_mode_for_crtc(crtc->base.state, &crtc->base.mode));

-:136: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#136: FILE: drivers/gpu/drm/i915/display/intel_display.c:17238:
+				/*
+				* FIXME don't have the fb yet, so can't

total: 0 errors, 4 warnings, 0 checks, 119 lines checked
87f053dd9d78 drm/i915: Prepare update_slave() for bigjoiner plane updates
-:138: WARNING:LONG_LINE: line over 100 characters
#138: FILE: drivers/gpu/drm/i915/display/intel_display.c:14806:
+			intel_atomic_get_new_plane_state(intel_state, new_plane_state->planar_linked_plane);

total: 0 errors, 1 warnings, 0 checks, 318 lines checked
5c48f75472bd drm/i915: Link planes in a bigjoiner configuration.
-:28: ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#28: FILE: drivers/gpu/drm/i915/display/intel_atomic_plane.c:185:
+struct intel_crtc *
+intel_plane_get_crtc_from_states(struct intel_atomic_state *state,
+				 const struct intel_plane_state *old_plane_state,
+				 const struct intel_plane_state *new_plane_state)
+  {

-:32: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#32: FILE: drivers/gpu/drm/i915/display/intel_atomic_plane.c:189:
+  {$

-:157: WARNING:LONG_LINE: line over 100 characters
#157: FILE: drivers/gpu/drm/i915/display/intel_display.c:11872:
+		for_each_oldnew_intel_plane_in_state(state, plane, old_plane_state, new_plane_state, i) {

total: 1 errors, 2 warnings, 0 checks, 242 lines checked
dfcb59743ad5 drm/i915: Program planes in bigjoiner mode.
-:49: WARNING:LONG_LINE: line over 100 characters
#49: FILE: drivers/gpu/drm/i915/display/intel_atomic_plane.c:395:
+				intel_atomic_get_new_plane_state(state, new_plane_state->bigjoiner_plane);

total: 0 errors, 1 warnings, 0 checks, 77 lines checked
a4c555a8c16c drm/i915: Add intel_update_bigjoiner handling.
-:51: WARNING:LONG_LINE: line over 100 characters
#51: FILE: drivers/gpu/drm/i915/display/intel_display.c:14331:
+		drm_calc_timestamping_constants(&slave->base, &new_slave_crtc_state->hw.transcoder_mode);

total: 0 errors, 1 warnings, 0 checks, 223 lines checked
fda4e645a05a drm/i915: Disable FBC in bigjoiner configuration.
b38045c74b32 drm/i915: Prepare atomic plane check for bigjoiner planes
-:35: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#35: FILE: drivers/gpu/drm/i915/display/intel_atomic.c:301:
+	if (plane_state && (plane_state->linked_plane ||
+	     (!plane_state->bigjoiner_slave && plane_state->base.fb &&

-:82: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#82: FILE: drivers/gpu/drm/i915/display/intel_atomic_plane.c:164:
+			intel_atomic_get_old_plane_state(state,
+					old_plane_state->bigjoiner_plane);

-:87: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#87: FILE: drivers/gpu/drm/i915/display/intel_atomic_plane.c:169:
+			intel_atomic_get_new_plane_state(state,
+					new_plane_state->bigjoiner_plane);

-:124: CHECK:LINE_SPACING: Please don't use multiple blank lines
#124: FILE: drivers/gpu/drm/i915/display/intel_atomic_plane.c:462:
 
+

-:360: WARNING:LONG_LINE: line over 100 characters
#360: FILE: drivers/gpu/drm/i915/display/intel_display.c:3394:
+		aux_offset = intel_plane_adjust_aligned_offset(&x, &y, master_plane_state, plane_state, 1,

-:394: WARNING:LONG_LINE: line over 100 characters
#394: FILE: drivers/gpu/drm/i915/display/intel_display.c:3452:
+		offset = intel_plane_adjust_aligned_offset(&x, &y, master_plane_state, plane_state, 0,

-:403: WARNING:LONG_LINE: line over 100 characters
#403: FILE: drivers/gpu/drm/i915/display/intel_display.c:3470:
+			offset = intel_plane_adjust_aligned_offset(&x, &y, master_plane_state, plane_state, 0,

-:412: WARNING:LONG_LINE: line over 100 characters
#412: FILE: drivers/gpu/drm/i915/display/intel_display.c:3480:
+		while (!skl_check_main_ccs_coordinates(master_plane_state, plane_state, x, y, offset)) {

-:417: WARNING:LONG_LINE: line over 100 characters
#417: FILE: drivers/gpu/drm/i915/display/intel_display.c:3484:
+			offset = intel_plane_adjust_aligned_offset(&x, &y, master_plane_state, plane_state, 0,

total: 0 errors, 5 warnings, 4 checks, 955 lines checked
00bf77afbf1c drm/i915: Make prepare_plane_fb() work with bigjoiner planes
-:133: WARNING:LONG_LINE: line over 100 characters
#133: FILE: drivers/gpu/drm/i915/display/intel_display.c:15050:
+			intel_atomic_get_new_plane_state(state, new_plane_state->planar_linked_plane);

-:142: WARNING:LONG_LINE: line over 100 characters
#142: FILE: drivers/gpu/drm/i915/display/intel_display.c:15065:
+		new_master_plane_state = intel_atomic_get_new_plane_state(state, new_plane_state->bigjoiner_plane);

total: 0 errors, 2 warnings, 0 checks, 167 lines checked
2f481b21d19e drm/i915: Make sure watermarks work correctly with bigjoiner as well.
-:32: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#32: FILE: drivers/gpu/drm/i915/display/intel_atomic.c:301:
+	if (plane_state && (plane_state->planar_linked_plane ||
 	     (!plane_state->bigjoiner_slave && plane_state->base.fb &&

-:73: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#73: FILE: drivers/gpu/drm/i915/display/intel_display.h:443:
+#define intel_atomic_crtc_state_for_each_plane_state( \
+		  plane, master_plane_state, plane_state, \
+		  crtc_state) \
+	for_each_intel_plane_mask(((crtc_state)->uapi.state->dev), (plane), \
+		  (((crtc_state)->bigjoiner_slave ? \
+			intel_atomic_get_new_crtc_state( \
+				to_intel_atomic_state((crtc_state)->uapi.state), \
+				(crtc_state)->bigjoiner_linked_crtc) : \
+				(crtc_state))->uapi.plane_mask)) \
+		for_each_if ((((master_plane_state) = \
+			      to_intel_plane_state(__drm_atomic_get_current_plane_state((crtc_state)->uapi.state, &plane->base))), \
+			      ((plane) = (master_plane_state)->bigjoiner_slave ? \
+					 (master_plane_state)->bigjoiner_plane : \
+					 (plane)), \
+			      ((plane_state) = (master_plane_state)->bigjoiner_slave ? \
+				to_intel_plane_state(__drm_atomic_get_current_plane_state((crtc_state)->uapi.state, &plane->base)) : \
+				  (master_plane_state))))

-:73: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plane' - possible side-effects?
#73: FILE: drivers/gpu/drm/i915/display/intel_display.h:443:
+#define intel_atomic_crtc_state_for_each_plane_state( \
+		  plane, master_plane_state, plane_state, \
+		  crtc_state) \
+	for_each_intel_plane_mask(((crtc_state)->uapi.state->dev), (plane), \
+		  (((crtc_state)->bigjoiner_slave ? \
+			intel_atomic_get_new_crtc_state( \
+				to_intel_atomic_state((crtc_state)->uapi.state), \
+				(crtc_state)->bigjoiner_linked_crtc) : \
+				(crtc_state))->uapi.plane_mask)) \
+		for_each_if ((((master_plane_state) = \
+			      to_intel_plane_state(__drm_atomic_get_current_plane_state((crtc_state)->uapi.state, &plane->base))), \
+			      ((plane) = (master_plane_state)->bigjoiner_slave ? \
+					 (master_plane_state)->bigjoiner_plane : \
+					 (plane)), \
+			      ((plane_state) = (master_plane_state)->bigjoiner_slave ? \
+				to_intel_plane_state(__drm_atomic_get_current_plane_state((crtc_state)->uapi.state, &plane->base)) : \
+				  (master_plane_state))))

-:73: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'master_plane_state' - possible side-effects?
#73: FILE: drivers/gpu/drm/i915/display/intel_display.h:443:
+#define intel_atomic_crtc_state_for_each_plane_state( \
+		  plane, master_plane_state, plane_state, \
+		  crtc_state) \
+	for_each_intel_plane_mask(((crtc_state)->uapi.state->dev), (plane), \
+		  (((crtc_state)->bigjoiner_slave ? \
+			intel_atomic_get_new_crtc_state( \
+				to_intel_atomic_state((crtc_state)->uapi.state), \
+				(crtc_state)->bigjoiner_linked_crtc) : \
+				(crtc_state))->uapi.plane_mask)) \
+		for_each_if ((((master_plane_state) = \
+			      to_intel_plane_state(__drm_atomic_get_current_plane_state((crtc_state)->uapi.state, &plane->base))), \
+			      ((plane) = (master_plane_state)->bigjoiner_slave ? \
+					 (master_plane_state)->bigjoiner_plane : \
+					 (plane)), \
+			      ((plane_state) = (master_plane_state)->bigjoiner_slave ? \
+				to_intel_plane_state(__drm_atomic_get_current_plane_state((crtc_state)->uapi.state, &plane->base)) : \
+				  (master_plane_state))))

-:73: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'crtc_state' - possible side-effects?
#73: FILE: drivers/gpu/drm/i915/display/intel_display.h:443:
+#define intel_atomic_crtc_state_for_each_plane_state( \
+		  plane, master_plane_state, plane_state, \
+		  crtc_state) \
+	for_each_intel_plane_mask(((crtc_state)->uapi.state->dev), (plane), \
+		  (((crtc_state)->bigjoiner_slave ? \
+			intel_atomic_get_new_crtc_state( \
+				to_intel_atomic_state((crtc_state)->uapi.state), \
+				(crtc_state)->bigjoiner_linked_crtc) : \
+				(crtc_state))->uapi.plane_mask)) \
+		for_each_if ((((master_plane_state) = \
+			      to_intel_plane_state(__drm_atomic_get_current_plane_state((crtc_state)->uapi.state, &plane->base))), \
+			      ((plane) = (master_plane_state)->bigjoiner_slave ? \
+					 (master_plane_state)->bigjoiner_plane : \
+					 (plane)), \
+			      ((plane_state) = (master_plane_state)->bigjoiner_slave ? \
+				to_intel_plane_state(__drm_atomic_get_current_plane_state((crtc_state)->uapi.state, &plane->base)) : \
+				  (master_plane_state))))

-:82: WARNING:SPACING: space prohibited between function name and open parenthesis '('
#82: FILE: drivers/gpu/drm/i915/display/intel_display.h:452:
+		for_each_if ((((master_plane_state) = \

-:83: WARNING:LONG_LINE: line over 100 characters
#83: FILE: drivers/gpu/drm/i915/display/intel_display.h:453:
+			      to_intel_plane_state(__drm_atomic_get_current_plane_state((crtc_state)->uapi.state, &plane->base))), \

-:88: WARNING:LONG_LINE: line over 100 characters
#88: FILE: drivers/gpu/drm/i915/display/intel_display.h:458:
+				to_intel_plane_state(__drm_atomic_get_current_plane_state((crtc_state)->uapi.state, &plane->base)) : \

-:116: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "master_plane_state->base.fb"
#116: FILE: drivers/gpu/drm/i915/intel_pm.c:835:
+		return master_plane_state->base.fb != NULL;

-:408: WARNING:TABSTOP: Statements should start on a tabstop
#408: FILE: drivers/gpu/drm/i915/intel_pm.c:4333:
+		  }

-:466: WARNING:LONG_LINE: line over 100 characters
#466: FILE: drivers/gpu/drm/i915/intel_pm.c:4763:
+				     skl_adjusted_plane_pixel_rate(crtc_state, master_plane_state, plane_state),

total: 1 errors, 5 warnings, 5 checks, 522 lines checked
6841b8e381a7 drm/i915: Add debugfs dumping for bigjoiner.
-:52: WARNING:LONG_LINE: line over 100 characters
#52: FILE: drivers/gpu/drm/i915/i915_debugfs.c:2682:
+		seq_printf(m, "\t--Plane id %d: type=%s, %sclipped crtc="DRM_RECT_FMT", clipped src="DRM_RECT_FP_FMT", format=%s, rotation=%s\n",

-:52: CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#52: FILE: drivers/gpu/drm/i915/i915_debugfs.c:2682:
+		seq_printf(m, "\t--Plane id %d: type=%s, %sclipped crtc="DRM_RECT_FMT", clipped src="DRM_RECT_FP_FMT", format=%s, rotation=%s\n",

total: 0 errors, 1 warnings, 1 checks, 65 lines checked
4fc8d6917d96 HAX to make it work on the icelake test system

More information about the Intel-gfx mailing list