[Intel-gfx] [PATCH] drm/i915/execlists: Drop redundant list_del_init(&rq->sched.link)

[Tvrtko Ursulin]

On 23/09/2019 10:40, Chris Wilson wrote:
> Since amalgamating the queued and active lists in commit 422d7df4f090
> ("drm/i915: Replace engine->timeline with a plain list"), performing a
> i915_request_submit() will remove the request from the execlists
> priority queue.
> 
> References: 422d7df4f090 ("drm/i915: Replace engine->timeline with a plain list")
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> ---
>   drivers/gpu/drm/i915/gt/intel_lrc.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
> index 1a2b71157f08..81f16b8ea0d0 100644
> --- a/drivers/gpu/drm/i915/gt/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
> @@ -2514,7 +2514,6 @@ static void execlists_cancel_requests(struct intel_engine_cs *engine)
>   		int i;
>   
>   		priolist_for_each_request_consume(rq, rn, p, i) {
> -			list_del_init(&rq->sched.link);
>   			__i915_request_submit(rq);
>   			dma_fence_set_error(&rq->fence, -EIO);
>   			i915_request_mark_complete(rq);
> 

Thanks! :)

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Regards,

Tvrtko