[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Gen12 E2E compression

Patchwork patchwork at emeril.freedesktop.org
Mon Sep 23 13:53:39 UTC 2019


== Series Details ==

Series: Gen12 E2E compression
URL   : https://patchwork.freedesktop.org/series/67078/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
b66ba0b6ed71 drm/framebuffer: Format modifier for Intel Gen-12 render compression
3d964432ccb8 drm/i915: Use intel_tile_height() instead of re-implementing
162c293caa32 drm/i915: Move CCS stride alignment W/A inside intel_fb_stride_alignment
684bed694380 drm/i915/tgl: Gen-12 render decompression
8c40f9ea2959 drm/i915: Extract framebufer CCS offset checks into a function
-:46: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#46: FILE: drivers/gpu/drm/i915/display/intel_display.c:2706:
+	/*
+	* CCS doesn't have its own x/y offset register, so the intra CCS tile

total: 0 errors, 1 warnings, 0 checks, 81 lines checked
be91a93ca86b drm/framebuffer: Format modifier for Intel Gen-12 media compression
7c44c2214c99 drm/i915: Skip rotated offset adjustment for unsupported modifiers
b518c6edfa29 drm/fb: Extend format_info member arrays to handle four planes
1a2bdfbf6347 Gen-12 display can decompress surfaces compressed by the media engine.
-:13: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#13: 
compressed buffers. Unlike render decompression, plane 6 and  plane 7 do not

-:113: WARNING:LONG_LINE: line over 100 characters
#113: FILE: drivers/gpu/drm/i915/display/intel_display.c:2704:
+intel_fb_plane_get_subsampling(int *hsub, int *vsub, const struct drm_framebuffer *fb, int color_plane)

-:120: WARNING:LONG_LINE: line over 100 characters
#120: FILE: drivers/gpu/drm/i915/display/intel_display.c:2711:
+		} mc_ccs_subsampling = {.cpp = {1, 1, 2, 1}, .hsub = {1, 8, 2, 16}, .vsub = {1, 32, 2, 32}};

-:120: ERROR:SPACING: space required after that close brace '}'
#120: FILE: drivers/gpu/drm/i915/display/intel_display.c:2711:
+		} mc_ccs_subsampling = {.cpp = {1, 1, 2, 1}, .hsub = {1, 8, 2, 16}, .vsub = {1, 32, 2, 32}};

-:136: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#136: FILE: drivers/gpu/drm/i915/display/intel_display.c:2727:
+	*w = fb->width/hsub;
 	              ^

-:137: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#137: FILE: drivers/gpu/drm/i915/display/intel_display.c:2728:
+	*h = fb->height/vsub;
 	               ^

-:324: CHECK:LINE_SPACING: Please don't use multiple blank lines
#324: FILE: drivers/gpu/drm/i915/display/intel_display.c:3663:
+
+

-:334: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#334: FILE: drivers/gpu/drm/i915/display/intel_display.c:3673:
+
+		}

total: 1 errors, 3 warnings, 4 checks, 511 lines checked



More information about the Intel-gfx mailing list