[Intel-gfx] [PATCH] drm/i915: Describe structure member in documentation

[Lucas De Marchi]

On Mon, Sep 23, 2019 at 03:56:40PM +0300, Anna Karas wrote:
>Add description of wakeref member of intel_shared_dpll structure to
>documentation.
>
>Cc: Lucas De Marchi <lucas.demarchi at intel.com>
>Cc: Vivek Kasireddy <vivek.kasireddy at intel.com>
>Signed-off-by: Anna Karas <anna.karas at intel.com>
>---
> drivers/gpu/drm/i915/display/intel_dpll_mgr.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.h b/drivers/gpu/drm/i915/display/intel_dpll_mgr.h
>index 104cf6d42333..e35dd6b04443 100644
>--- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.h
>+++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.h
>@@ -337,6 +337,11 @@ struct intel_shared_dpll {
> 	 * @info: platform specific info
> 	 */
> 	const struct dpll_info *info;
>+
>+	/**
>+	 * @wakeref: A device-level runtime pm reference grabbed only if
>+	 * it is powered on.
>+	 */

but this is only grabbed for DPLL4, on EHL.

"In some platforms a device-level runtime pm reference may need to be
grabbed to disable DC states while this DPLL is enabled" would be more
appropriate IMO.

Lucas De Marchi

> 	intel_wakeref_t wakeref;
> };
>
>-- 
>2.19.0
>