[Intel-gfx] [PATCH 23/27] drm/i915: Drop struct_mutex guard from debugfs/framebuffer_info

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Wed Sep 25 12:45:15 UTC 2019


On 25/09/2019 11:01, Chris Wilson wrote:
> It protects nothing being accessed for the intel_framebuffer, so it's
> own locking had better be sufficient.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>   drivers/gpu/drm/i915/i915_debugfs.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index d4a7cda60679..5e984ba27bef 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -1445,11 +1445,6 @@ static int i915_gem_framebuffer_info(struct seq_file *m, void *data)
>   	struct drm_device *dev = &dev_priv->drm;
>   	struct intel_framebuffer *fbdev_fb = NULL;
>   	struct drm_framebuffer *drm_fb;
> -	int ret;
> -
> -	ret = mutex_lock_interruptible(&dev->struct_mutex);
> -	if (ret)
> -		return ret;
>   
>   #ifdef CONFIG_DRM_FBDEV_EMULATION
>   	if (dev_priv->fbdev && dev_priv->fbdev->helper.fb) {
> @@ -1484,7 +1479,6 @@ static int i915_gem_framebuffer_info(struct seq_file *m, void *data)
>   		seq_putc(m, '\n');
>   	}
>   	mutex_unlock(&dev->mode_config.fb_lock);
> -	mutex_unlock(&dev->struct_mutex);
>   
>   	return 0;
>   }
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Regards,

Tvrtko


More information about the Intel-gfx mailing list