[Intel-gfx] [PATCH 24/27] drm/i915: Remove struct_mutex guard for debugfs/opregion

[Tvrtko Ursulin]

On 25/09/2019 11:01, Chris Wilson wrote:
> Having a struct_mutex around the read of a BIOS blob serves no purpose.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>   drivers/gpu/drm/i915/i915_debugfs.c | 12 +-----------
>   1 file changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 5e984ba27bef..8f48f2543b7c 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -1411,21 +1411,11 @@ static int i915_ring_freq_table(struct seq_file *m, void *unused)
>   
>   static int i915_opregion(struct seq_file *m, void *unused)
>   {
> -	struct drm_i915_private *dev_priv = node_to_i915(m->private);
> -	struct drm_device *dev = &dev_priv->drm;
> -	struct intel_opregion *opregion = &dev_priv->opregion;
> -	int ret;
> -
> -	ret = mutex_lock_interruptible(&dev->struct_mutex);
> -	if (ret)
> -		goto out;
> +	struct intel_opregion *opregion = &node_to_i915(m->private)->opregion;
>   
>   	if (opregion->header)
>   		seq_write(m, opregion->header, OPREGION_SIZE);
>   
> -	mutex_unlock(&dev->struct_mutex);
> -
> -out:
>   	return 0;
>   }
>   
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Regards,

Tvrtko