[Intel-gfx] [PATCH 12/27] drm/i915: Move request runtime management onto gt

[Tvrtko Ursulin]

On 25/09/2019 12:33, Chris Wilson wrote:
> Quoting Chris Wilson (2019-09-25 12:29:40)
>> Quoting Chris Wilson (2019-09-25 12:24:08)
>>> Quoting Chris Wilson (2019-09-25 12:17:14)
>>>> Quoting Tvrtko Ursulin (2019-09-25 11:57:53)
>>>>>
>>>>> I am still slightly uneasy about having requests, which I see as a GEM
>>>>> concept, be retired from GT, but okay, it's not the most important issue
>>>>> at the moment.
>>>>
>>>> requests are not a GEM concept, they belong in sched/ :)
>>>
>>> Overall though, the compartmentalisation is intel_gt based. Our
>>> timelines and their powermanagement is associated with the gt, so that's
>>> where it feels necessary to provide the background cleanup. If we drop
>>> the timeline->gt, then I think it's time for a new home?
>>
>> Actually would a simple s//intel_gt_retire_timelines()/ make it more
>> palatable?
> 
> Or even just intel_gt_retire()

This bit is fine as it is. As we have both pointed out there is natural 
and unavoidable intertwining between GEM and GT and that's completely 
natural. As long as we have clear APIs between the two (so those helpers 
I was suggesting) I am happy.

Regards,

Tvrtko