[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Gen12 E2E compression (rev2)

Patchwork patchwork at emeril.freedesktop.org
Thu Sep 26 11:01:50 UTC 2019


== Series Details ==

Series: Gen12 E2E compression (rev2)
URL   : https://patchwork.freedesktop.org/series/67078/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
b4a0858736dc drm/framebuffer: Format modifier for Intel Gen-12 render compression
97529f698ecd drm/i915: Use intel_tile_height() instead of re-implementing
e0aac1d19bd8 drm/i915: Move CCS stride alignment W/A inside intel_fb_stride_alignment
32db1b3e4687 drm/i915/tgl: Gen-12 render decompression
f9b5443feb41 drm/i915: Extract framebufer CCS offset checks into a function
-:46: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#46: FILE: drivers/gpu/drm/i915/display/intel_display.c:2706:
+	/*
+	* CCS doesn't have its own x/y offset register, so the intra CCS tile

total: 0 errors, 1 warnings, 0 checks, 81 lines checked
3815b3cf3f91 drm/framebuffer: Format modifier for Intel Gen-12 media compression
70f5e38938bb drm/i915: Skip rotated offset adjustment for unsupported modifiers
1a74294adf44 drm/fb: Extend format_info member arrays to handle four planes
cd165d81961a Gen-12 display can decompress surfaces compressed by the media engine.
-:13: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#13: 
compressed buffers. Unlike render decompression, plane 6 and  plane 7 do not

-:230: WARNING:LONG_LINE: line over 100 characters
#230: FILE: drivers/gpu/drm/i915/display/intel_display.c:2723:
+intel_fb_plane_get_subsampling(int *hsub, int *vsub, const struct drm_framebuffer *fb, int color_plane)

-:264: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#264: FILE: drivers/gpu/drm/i915/display/intel_display.c:2757:
+	*w = fb->width/hsub;
 	              ^

-:265: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#265: FILE: drivers/gpu/drm/i915/display/intel_display.c:2758:
+	*h = fb->height/vsub;
 	               ^

-:415: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#415: FILE: drivers/gpu/drm/i915/display/intel_display.c:3627:
 	if (is_ccs_modifier(fb->modifier)) {
+

-:443: CHECK:LINE_SPACING: Please don't use multiple blank lines
#443: FILE: drivers/gpu/drm/i915/display/intel_display.c:3689:
+
+

-:453: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#453: FILE: drivers/gpu/drm/i915/display/intel_display.c:3699:
+
+		}

-:496: CHECK:SPACING: spaces preferred around that '/' (ctx:VxW)
#496: FILE: drivers/gpu/drm/i915/display/intel_display.c:3738:
+		intel_fb_plane_get_subsampling(&main_hsub, &main_vsub, fb, (ccs - 1)/ 2);
 		                                                                    ^

total: 0 errors, 2 warnings, 6 checks, 659 lines checked



More information about the Intel-gfx mailing list