[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for LMEM basics

Patchwork patchwork at emeril.freedesktop.org
Fri Sep 27 18:29:20 UTC 2019 

== Series Details ==

Series: LMEM basics
URL   : https://patchwork.freedesktop.org/series/67350/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
ccc51e3ac24e drm/i915: check for kernel_context
dbbfe24cafca drm/i915: simplify i915_gem_init_early
f52b9b0685d8 drm/i915: introduce intel_memory_region
-:59: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#59: 
new file mode 100644

-:562: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_memory_region *' should also have an identifier name
#562: FILE: drivers/gpu/drm/i915/intel_memory_region.h:25:
+	int (*init)(struct intel_memory_region *);

-:563: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_memory_region *' should also have an identifier name
#563: FILE: drivers/gpu/drm/i915/intel_memory_region.h:26:
+	void (*release)(struct intel_memory_region *);

-:565: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_memory_region *' should also have an identifier name
#565: FILE: drivers/gpu/drm/i915/intel_memory_region.h:28:
+	struct drm_i915_gem_object *

-:565: WARNING:FUNCTION_ARGUMENTS: function definition argument 'resource_size_t' should also have an identifier name
#565: FILE: drivers/gpu/drm/i915/intel_memory_region.h:28:
+	struct drm_i915_gem_object *

-:565: WARNING:FUNCTION_ARGUMENTS: function definition argument 'unsigned int' should also have an identifier name
#565: FILE: drivers/gpu/drm/i915/intel_memory_region.h:28:
+	struct drm_i915_gem_object *

-:580: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#580: FILE: drivers/gpu/drm/i915/intel_memory_region.h:43:
+	struct mutex mm_lock;

-:599: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#599: FILE: drivers/gpu/drm/i915/intel_memory_region.h:62:
+__intel_memory_region_get_block_buddy(struct intel_memory_region *mem,
+				     resource_size_t size);

-:601: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#601: FILE: drivers/gpu/drm/i915/intel_memory_region.h:64:
+void __intel_memory_region_put_pages_buddy(struct intel_memory_region *mem,
+					  struct list_head *blocks);

-:709: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'igt_mock_fill', this function's name, in a string
#709: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:80:
+			pr_err("igt_mock_fill failed, space still left in region\n");

total: 0 errors, 7 warnings, 3 checks, 759 lines checked
6d8c4bbbc790 drm/i915/region: support continuous allocations
-:227: WARNING:LINE_SPACING: Missing a blank line after declarations
#227: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:133:
+	LIST_HEAD(holes);
+	I915_RND_STATE(prng);

total: 0 errors, 1 warnings, 0 checks, 307 lines checked
c6f24f30618c drm/i915/region: support volatile objects
b5655dcc6d84 drm/i915: Add memory region information to device_info
a066bf23d40b drm/i915: support creating LMEM objects
-:35: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#35: 
new file mode 100644

-:117: WARNING:TYPO_SPELLING: 'UKNOWN' may be misspelled - perhaps 'UNKNOWN'?
#117: FILE: drivers/gpu/drm/i915/i915_drv.h:684:
+	struct intel_memory_region *regions[INTEL_MEMORY_UKNOWN];

-:168: WARNING:TYPO_SPELLING: 'UKNOWN' may be misspelled - perhaps 'UNKNOWN'?
#168: FILE: drivers/gpu/drm/i915/intel_memory_region.h:33:
+	INTEL_MEMORY_UKNOWN, /* Should be last */

-:177: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'r' may be better as '(r)' to avoid precedence issues
#177: FILE: drivers/gpu/drm/i915/intel_memory_region.h:42:
+#define MEMORY_TYPE_FROM_REGION(r) (ilog2(r >> INTEL_MEMORY_TYPE_SHIFT))

-:178: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'r' may be better as '(r)' to avoid precedence issues
#178: FILE: drivers/gpu/drm/i915/intel_memory_region.h:43:
+#define MEMORY_INSTANCE_FROM_REGION(r) (ilog2(r & 0xffff))

total: 0 errors, 3 warnings, 2 checks, 265 lines checked
63ad9888746c drm/i915: setup io-mapping for LMEM
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 34 lines checked
1dd672af1e42 drm/i915/lmem: support kernel mapping
-:289: ERROR:CODE_INDENT: code indent should use tabs where possible
#289: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:323:
+^I^I^I        val);$

-:289: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#289: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:323:
+			pr_err("vaddr[%u]=%u, val=%u\n", dword, vaddr[dword],
+			        val);

-:301: ERROR:CODE_INDENT: code indent should use tabs where possible
#301: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:335:
+^I^I^I        val ^ 0xdeadbeaf);$

-:301: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#301: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:335:
+			pr_err("vaddr[%u]=%u, val=%u\n", dword, vaddr[dword],
+			        val ^ 0xdeadbeaf);

total: 2 errors, 0 warnings, 2 checks, 263 lines checked
76154df5dd82 drm/i915/selftests: add write-dword test for LMEM
-:19: CHECK:LINE_SPACING: Please don't use multiple blank lines
#19: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:10:
 
+

-:96: WARNING:LINE_SPACING: Missing a blank line after declarations
#96: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:321:
+	struct intel_context *ce;
+	I915_RND_STATE(prng);

-:176: WARNING:LINE_SPACING: Missing a blank line after declarations
#176: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:415:
+	struct drm_file *file;
+	I915_RND_STATE(prng);

total: 0 errors, 2 warnings, 1 checks, 210 lines checked
970fd335c3b3 drm/i915/selftest: extend coverage to include LMEM huge-pages
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 151 lines checked
91e43c262159 drm/i915: enumerate and init each supported region
19270051b021 drm/i915: treat shmem as a region
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

-:116: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#116: FILE: drivers/gpu/drm/i915/gem/i915_gem_shmem.c:444:
+static int __create_shmem(struct drm_i915_private *i915,
 			struct drm_gem_object *obj,

-:128: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#128: FILE: drivers/gpu/drm/i915/gem/i915_gem_shmem.c:467:
+	     unsigned flags)

-:190: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17)
#190: FILE: drivers/gpu/drm/i915/gem/i915_gem_shmem.c:591:
+	if (err)
+		 DRM_NOTE("Unable to create a private tmpfs mount, hugepage support will be disabled(%d).\n", err);

-:191: WARNING:LONG_LINE: line over 100 characters
#191: FILE: drivers/gpu/drm/i915/gem/i915_gem_shmem.c:592:
+		 DRM_NOTE("Unable to create a private tmpfs mount, hugepage support will be disabled(%d).\n", err);

total: 0 errors, 4 warnings, 1 checks, 346 lines checked
82bde2d03644 drm/i915: treat stolen as a region
8355d01685d9 drm/i915: define HAS_MAPPABLE_APERTURE
-:20: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'dev_priv' may be better as '(dev_priv)' to avoid precedence issues
#20: FILE: drivers/gpu/drm/i915/i915_drv.h:2122:
+#define HAS_MAPPABLE_APERTURE(dev_priv) (dev_priv->ggtt.mappable_end > 0)

total: 0 errors, 0 warnings, 1 checks, 8 lines checked
2199f453f083 drm/i915: do not map aperture if it is not available.
-:38: CHECK:SPACING: No space is necessary after a cast
#38: FILE: drivers/gpu/drm/i915/i915_gem_gtt.c:3046:
+			(struct resource) DEFINE_RES_MEM(pci_resource_start(pdev, 2),

total: 0 errors, 0 warnings, 1 checks, 53 lines checked
4a7487273a64 drm/i915: set num_fence_regs to 0 if there is no aperture
9d82c4a319bc drm/i915/selftests: check for missing aperture
f722fde71ba0 drm/i915: error capture with no ggtt slot
-:175: WARNING:LINE_SPACING: Missing a blank line after declarations
#175: FILE: drivers/gpu/drm/i915/i915_gpu_error.c:1720:
+		const u64 slot = ggtt->error_capture.start;
+		ggtt->vm.clear_range(&ggtt->vm, slot, PAGE_SIZE);

total: 0 errors, 1 warnings, 0 checks, 149 lines checked
097c34ca5081 drm/i915: Don't try to place HWS in non-existing mappable region
2f657bf00d3c drm/i915: check for missing aperture in GTT pread/pwrite paths
e2124597ca45 HAX drm/i915: add the fake lmem region
-:49: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...
#49: FILE: arch/x86/kernel/early-quirks.c:624:
+	printk(KERN_INFO "Intel graphics fake LMEM starts at %pa\n",

total: 0 errors, 1 warnings, 0 checks, 228 lines checked

More information about the Intel-gfx mailing list