[Intel-gfx] [PATCH] drm/i915/guc: Update H2G enable logging action definition

Daniele Ceraolo Spurio daniele.ceraolospurio at intel.com
Fri Sep 27 21:24:16 UTC 2019



On 9/27/19 11:04 AM, Robert M. Fosha wrote:
> GuC enable logging H2G action definition changed some time ago from 0xE000
> to 0x40. All current GuC FW blobs use this definition, so fix the action
> definition in driver to match.
> 
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Signed-off-by: Robert M. Fosha <robert.m.fosha at intel.com>

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>

We really need to add some proper testing for the guc log relay, 
otherwise we'll only notice bugs in there (like this one) when we need 
to use the relay for debug of other issues.

Daniele

> ---
>   drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h b/drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h
> index 1d3cdd67ca2f..a26a85d50209 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h
> @@ -548,6 +548,7 @@ enum intel_guc_action {
>   	INTEL_GUC_ACTION_ALLOCATE_DOORBELL = 0x10,
>   	INTEL_GUC_ACTION_DEALLOCATE_DOORBELL = 0x20,
>   	INTEL_GUC_ACTION_LOG_BUFFER_FILE_FLUSH_COMPLETE = 0x30,
> +	INTEL_GUC_ACTION_UK_LOG_ENABLE_LOGGING = 0x40,
>   	INTEL_GUC_ACTION_FORCE_LOG_BUFFER_FLUSH = 0x302,
>   	INTEL_GUC_ACTION_ENTER_S_STATE = 0x501,
>   	INTEL_GUC_ACTION_EXIT_S_STATE = 0x502,
> @@ -556,7 +557,6 @@ enum intel_guc_action {
>   	INTEL_GUC_ACTION_AUTHENTICATE_HUC = 0x4000,
>   	INTEL_GUC_ACTION_REGISTER_COMMAND_TRANSPORT_BUFFER = 0x4505,
>   	INTEL_GUC_ACTION_DEREGISTER_COMMAND_TRANSPORT_BUFFER = 0x4506,
> -	INTEL_GUC_ACTION_UK_LOG_ENABLE_LOGGING = 0x0E000,
>   	INTEL_GUC_ACTION_LIMIT
>   };
>   
> 


More information about the Intel-gfx mailing list