[Intel-gfx] [PATCH] Make is_signed_type() simpler

Rasmus Villemoes linux at rasmusvillemoes.dk
Sun Sep 29 20:21:48 UTC 2019


On 29/09/2019 22.06, Alexey Dobriyan wrote:
> * Simply compare -1 with 0,
> * Drop unnecessary parenthesis sets
> 
> -#define is_signed_type(type)       (((type)(-1)) < (type)1)
> +#define is_signed_type(type)       ((type)-1 < 0)

NAK. I wrote it that way to avoid -Wtautological-compare when type is
unsigned.

Rasmus


More information about the Intel-gfx mailing list