[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for CRTC background color (rev8)

Patchwork patchwork at emeril.freedesktop.org
Mon Sep 30 23:04:13 UTC 2019


== Series Details ==

Series: CRTC background color (rev8)
URL   : https://patchwork.freedesktop.org/series/50834/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
ce8779b97946 drm: Add CRTC background color property
-:255: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'shift' - possible side-effects?
#255: FILE: include/uapi/drm/drm_mode.h:1049:
+#define DRM_ARGB_COMP(c, shift, numbits) \
+	(__u16)(((c) & 0xFFFFull << (shift)) >> ((shift) + 16 - (numbits)))

total: 0 errors, 0 warnings, 1 checks, 151 lines checked
fbe4bbbe8aec drm/i915/gen9+: Add support for pipe background color
52e2c82f7a75 drm/i915: Add background color hardware readout and state check
-:66: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name' - possible side-effects?
#66: FILE: drivers/gpu/drm/i915/display/intel_display.c:12656:
+#define PIPE_CONF_CHECK_LLX_MASKED(name, mask) do { \
+	if ((current_config->name & mask) != (pipe_config->name & mask)) { \
+		pipe_config_mismatch(fastset, __stringify(name), \
+				     "(expected 0x%016llx, found 0x%016llx)\n", \
+				     current_config->name & mask, \
+				     pipe_config->name & mask); \
+		ret = false; \
+	} \
+} while (0)

-:66: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues
#66: FILE: drivers/gpu/drm/i915/display/intel_display.c:12656:
+#define PIPE_CONF_CHECK_LLX_MASKED(name, mask) do { \
+	if ((current_config->name & mask) != (pipe_config->name & mask)) { \
+		pipe_config_mismatch(fastset, __stringify(name), \
+				     "(expected 0x%016llx, found 0x%016llx)\n", \
+				     current_config->name & mask, \
+				     pipe_config->name & mask); \
+		ret = false; \
+	} \
+} while (0)

-:66: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mask' - possible side-effects?
#66: FILE: drivers/gpu/drm/i915/display/intel_display.c:12656:
+#define PIPE_CONF_CHECK_LLX_MASKED(name, mask) do { \
+	if ((current_config->name & mask) != (pipe_config->name & mask)) { \
+		pipe_config_mismatch(fastset, __stringify(name), \
+				     "(expected 0x%016llx, found 0x%016llx)\n", \
+				     current_config->name & mask, \
+				     pipe_config->name & mask); \
+		ret = false; \
+	} \
+} while (0)

-:66: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'mask' may be better as '(mask)' to avoid precedence issues
#66: FILE: drivers/gpu/drm/i915/display/intel_display.c:12656:
+#define PIPE_CONF_CHECK_LLX_MASKED(name, mask) do { \
+	if ((current_config->name & mask) != (pipe_config->name & mask)) { \
+		pipe_config_mismatch(fastset, __stringify(name), \
+				     "(expected 0x%016llx, found 0x%016llx)\n", \
+				     current_config->name & mask, \
+				     pipe_config->name & mask); \
+		ret = false; \
+	} \
+} while (0)

total: 0 errors, 0 warnings, 4 checks, 62 lines checked



More information about the Intel-gfx mailing list