[Intel-gfx] [patch] PCI ID review

[Chris Wilson]

Quoting Ville Syrjälä (2020-04-27 15:02:48)
> On Sun, Apr 26, 2020 at 11:22:32PM -0400, Alexei Podtelezhnikov wrote:
> > In reverse order:
> > - Add SKL GT1.5
> > - Remove wrong and non-existant devices
> > - Add Gen3/Gen4 twin IGDs
> > - Amend historic records 
> 
> Please split into separate patches and justify each with
> a proper commit message.
> 
> > 
> > Signed-off-by: Alexei Podtelezhnikov <apodtele at gmail.com>
> > ---
> >  src/i915_pciids.h | 72 +++++++++++++++++++++++++++++++++++++------------------
> >  1 file changed, 49 insertions(+), 23 deletions(-)
> > 
> > diff --git a/src/i915_pciids.h b/src/i915_pciids.h
> > index 1d2c1221..a9c88eab 100644
> > --- a/src/i915_pciids.h
> > +++ b/src/i915_pciids.h
> > @@ -47,7 +47,11 @@ Amend historic records
> >       0x030000, 0xff0000,                     \
> >       (unsigned long) info }
> >  
> > +#define INTEL_I740_IDS(info)                                 \
> > +     INTEL_VGA_DEVICE(0x7800, info)  /* I740 */
> > +
> >  #define INTEL_I810_IDS(info)                                 \
> > +     INTEL_VGA_DEVICE(0x1240, info), /* I752 */              \
> >       INTEL_VGA_DEVICE(0x7121, info), /* I810 */              \
> >       INTEL_VGA_DEVICE(0x7123, info), /* I810_DC100 */        \
> >       INTEL_VGA_DEVICE(0x7125, info)  /* I810_E */
> > @@ -62,57 +66,79 @@ Add Gen3/Gen4 twin IGDs
> >       INTEL_VGA_DEVICE(0x2562, info)
> >  
> >  #define INTEL_I85X_IDS(info)                         \
> > -     INTEL_VGA_DEVICE(0x3582, info), /* I855_GM */ \
> > -     INTEL_VGA_DEVICE(0x358e, info)
> > +     INTEL_VGA_DEVICE(0x3582, info), /* I855_GM */   \
> > +     INTEL_VGA_DEVICE(0x358e, info)  /* I854 */
> >  
> >  #define INTEL_I865G_IDS(info)                                \
> >       INTEL_VGA_DEVICE(0x2572, info) /* I865_G */
> >  
> >  #define INTEL_I915G_IDS(info)                                \
> > -     INTEL_VGA_DEVICE(0x2582, info), /* I915_G */ \
> > +     INTEL_VGA_DEVICE(0x2582, info), /* I915_G */    \
> > +     INTEL_VGA_DEVICE(0x2782, info), /* I915_G */    \
> >       INTEL_VGA_DEVICE(0x258a, info)  /* E7221_G */
> >  
> >  #define INTEL_I915GM_IDS(info)                               \
> > -     INTEL_VGA_DEVICE(0x2592, info) /* I915_GM */
> > +     INTEL_VGA_DEVICE(0x2592, info), /* I915_GM */   \
> > +     INTEL_VGA_DEVICE(0x2792, info)  /* I915_GM */
> >  
> >  #define INTEL_I945G_IDS(info)                                \
> > -     INTEL_VGA_DEVICE(0x2772, info) /* I945_G */
> > +     INTEL_VGA_DEVICE(0x2772, info), /* I945_G */    \
> > +     INTEL_VGA_DEVICE(0x2776, info)  /* I945_G */
> >  
> >  #define INTEL_I945GM_IDS(info)                               \
> > -     INTEL_VGA_DEVICE(0x27a2, info), /* I945_GM */ \
> > +     INTEL_VGA_DEVICE(0x27a2, info), /* I945_GM */   \
> > +     INTEL_VGA_DEVICE(0x27a6, info), /* I945_GM */   \
> >       INTEL_VGA_DEVICE(0x27ae, info)  /* I945_GME */
> >  
> >  #define INTEL_I965G_IDS(info)                                \
> >       INTEL_VGA_DEVICE(0x2972, info), /* I946_GZ */   \
> > +     INTEL_VGA_DEVICE(0x2973, info), /* I946_GZ */   \

These do not exist. They are fake PCI-ID for Windows95 multi monitor.
The single device appears twice on the bus as a second function. We
never had that restriction and could do multiple monitors on the single
device.
-Chris