[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt:fix raw-wakeref not held calltrace in vGPU (rev2)

Patchwork patchwork at emeril.freedesktop.org
Tue Aug 11 10:29:25 UTC 2020


== Series Details ==

Series: drm/i915/gt:fix raw-wakeref not held calltrace in vGPU (rev2)
URL   : https://patchwork.freedesktop.org/series/80497/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
ecbbc5815c0f drm/i915: Drop runtime-pm assert from vgpu io accessors
-:16: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#16: 
References: 3be0bf5acca6 ("drm/i915: Create vGPU specific MMIO operations to reduce traps")

-:16: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 3be0bf5acca6 ("drm/i915: Create vGPU specific MMIO operations to reduce traps")'
#16: 
References: 3be0bf5acca6 ("drm/i915: Create vGPU specific MMIO operations to reduce traps")

-:29: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#29: FILE: drivers/gpu/drm/i915/intel_uncore.c:1212:
+#define __vgpu_read(x) \
+static u##x \
+vgpu_read##x(struct intel_uncore *uncore, i915_reg_t reg, bool trace) { \
+	u##x val = __raw_uncore_read##x(uncore, reg); \
+	trace_i915_reg_rw(false, reg, val, sizeof(val), trace); \
+	return val; \
+}

-:36: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#36: FILE: drivers/gpu/drm/i915/intel_uncore.c:1219:
+}
+__vgpu_read(8)

-:54: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#54: FILE: drivers/gpu/drm/i915/intel_uncore.c:1435:
+}
+__vgpu_write(8)

total: 2 errors, 1 warnings, 2 checks, 45 lines checked




More information about the Intel-gfx mailing list