[Intel-gfx] [PATCH 4/4] drm/i915: split fdi code out from intel_display.c

Dave Airlie airlied at gmail.com
Thu Dec 10 01:32:18 UTC 2020


On Wed, 9 Dec 2020 at 20:48, Daniel Vetter <daniel at ffwll.ch> wrote:
>
> On Wed, Dec 9, 2020 at 5:22 AM Dave Airlie <airlied at gmail.com> wrote:
> >
> > From: Dave Airlie <airlied at redhat.com>
> >
> > This just refactors out the fdi code to a separate file.
> >
> > Signed-off-by: Dave Airlie <airlied at redhat.com>
>
> There's also hsw_fdi_link_train from intel_ddi.c (another fairly big
> file), I think that also belongs in here. It's not in the vtable
> because it's directly called from the hsw crt encoder. With that this
> looks reasonable to me.

It does but it's definitely a lot messier to move, it has a lot of
links into the ddi code and tables.

I'll add another patch to the end that we can look at to decide if
there's a cleaner way to do it.

Dave.


More information about the Intel-gfx mailing list