[Intel-gfx] [RFC] drm/i915: Restrict legacy color key ioctl to pre-gen12

Chris Wilson chris at chris-wilson.co.uk
Tue Jan 14 22:54:50 UTC 2020


Quoting Chris Wilson (2020-01-14 22:47:58)
> Quoting Matt Roper (2020-01-14 22:45:08)
> > Since gen12 platform support isn't finalized yet, let's kill off the
> > legacy color key ioctl for this platform; there's no userspace today
> > that can run on this platform that utilizes this legacy ioctl, so we can
> > safely kill it now before it becomes ABI.
> > 
> > Color key functionality never got integrated into the property / atomic
> > interface, and the only known open source consumer was the Intel DDX
> > which was never updated to run on platforms beyond gen9.  If color
> > keying is desired going forward, it should really be exposed as a
> > property so that it can be applied atomically with other display updates
> > (and should probably be standardized in a way all drivers can choose to
> > support rather than being i915-specific).
> 
> But it does run on those platforms and exposes the sprite plane via Xv.

What you can say is that the color_key is not required by the Xv sprite
code. We will just unfortunately advertise it to clients, but not
actually do anything.
-Chris


More information about the Intel-gfx mailing list