[Intel-gfx] [RFC 00/33] drm/i915/display: mass conversion to intel_de_*() register accessors

Rodrigo Vivi rodrigo.vivi at intel.com
Fri Jan 24 22:30:19 UTC 2020


On Fri, Jan 24, 2020 at 01:54:58PM +0000, Chris Wilson wrote:
> Quoting Jani Nikula (2020-01-24 13:25:21)
> > Hey all,
> > 
> > So I sent [1] to convert some forcewake register accessors... but what if we
> > just ripped off the bandage once and for all? It's going to hurt, a lot, but
> > we'd get it done.
> > 
> > This completely rids us of the "dev_priv" dependency in display/.
> > 
> > All the patches here are per-file and independent of each other. We could also
> > pick and apply the ones that are least likely to conflict.
> > 
> > Opinions?
> > 
> > 
> > BR,
> > Jani.
> > 
> > 
> > PS. I didn't bother looking at the checkpatch warnings this may generate at this
> > point. I just used the --linux-spacing option for spatch, and closed my eyes. I
> > completely scripted the generation of the series, apart from just a couple of
> > build fixes.
> 
> Yup. Suck it all in, clean up with the usual code refreshes.
> Schadenfreude-by: Chris Wilson <chris at chris-wilson.co.uk>
> 
> I've looked at a couple of patches to confirm that it does appear purely
> mechanical,
> Acked-by: Chris Wilson <chris at chris-wilson.co.uk>

Since it is purely mechanical with coccinelle, why not to make in only one patch?

Anyway:
Acked-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

> -Chris
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx


More information about the Intel-gfx mailing list