[Intel-gfx] [PATCH 6/9] drm/i915/dsb: Inline DSB_CTRL writes into intel_dsb_commit()

Chris Wilson chris at chris-wilson.co.uk
Wed Jan 29 18:32:04 UTC 2020


Quoting Ville Syrjala (2020-01-29 18:20:31)
> +       intel_de_write(dev_priv, DSB_CTRL(pipe, dsb->id),
> +                      DSB_ENABLE);
> +       intel_de_write(dev_priv, DSB_HEAD(pipe, dsb->id),
> +                      i915_ggtt_offset(dsb->vma));
>         intel_de_write(dev_priv, DSB_TAIL(pipe, dsb->id),
>                        i915_ggtt_offset(dsb->vma) + tail);

I still say this order looks dodgy for a ringbuffer. Is it all truly
latched by DSB_TAIL or might it start passing on being enabled and HEAD
!= TAIL?
-Chris


More information about the Intel-gfx mailing list