[Intel-gfx] [PATCH 1/2] drm/i915: extract engine WA programming to common resume function

[Chris Wilson]

Quoting Daniele Ceraolo Spurio (2020-01-29 23:58:59)
> The workarounds are a common "feature" across gens and submission
> mechanisms and we already call the other WA related functions from
> common engine ones (<setup/cleanup>_common), so it makes sense to
> do the same with WA application. Medium-term, This will help us
> reduce the duplication once the GuC resume function is added, but short
> term it will also allow us to use the workaround lists for pre-gen8
> engine workarounds.
> 
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com>
> Cc: Matthew Brost <matthew.brost at intel.com>

Ok, we've already made the apply functions gentle and not blow up when
called on early gen, and moving the apply into a common path doesn't
hinder future plans.

The only counter argument is that this is building a midlayer, and that
the point of vfuncs is that you call into the backend and the backend
picks and chooses which helpers to use.

So we have to be really confident that this is truly universal and not a
trap for future. But at the same time, we're quite adapt at
deconstructing when we need to.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris