[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: dbuf cleanups

Patchwork patchwork at emeril.freedesktop.org
Fri Apr 16 17:25:05 UTC 2021


== Series Details ==

Series: drm/i915: dbuf cleanups
URL   : https://patchwork.freedesktop.org/series/89171/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
c4e158b6022a drm/i915: Collect dbuf device info into a sub-struct
3bcf75a562a4 drm/i915: Handle dbuf bypass path allocation earlier
-:33: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations
#33: FILE: drivers/gpu/drm/i915/i915_pci.c:723:
+	.dbuf.size = 512 - 4, /* 4 blocks for bypass path allocation */ \

-:41: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations
#41: FILE: drivers/gpu/drm/i915/i915_pci.c:730:
+	.dbuf.size = 1024 - 4, /* 4 blocks for bypass path allocation */ \

total: 0 errors, 2 warnings, 0 checks, 47 lines checked
6182af680aea drm/i915: Store dbuf slice mask in device info
4bec22613175 drm/i915: Use intel_dbuf_slice_size()
407ca0202e11 drm/i915: Use intel_de_rmw() for DBUF_POWER_REQUEST
bbfbba08f9aa drm/i915: Polish for_each_dbuf_slice()
-:79: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__slice' - possible side-effects?
#79: FILE: drivers/gpu/drm/i915/display/intel_display.h:191:
+#define for_each_dbuf_slice(__dev_priv, __slice) \
 	for ((__slice) = DBUF_S1; (__slice) < I915_MAX_DBUF_SLICES; (__slice)++) \
+		for_each_if(INTEL_INFO(__dev_priv)->dbuf.slice_mask & BIT(__slice))

-:86: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#86: FILE: drivers/gpu/drm/i915/display/intel_display.h:195:
+#define for_each_dbuf_slice_in_mask(__dev_priv, __slice, __mask) \
+	for_each_dbuf_slice((__dev_priv), (__slice)) \
+		for_each_if((__mask) & BIT(__slice))

-:86: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__slice' - possible side-effects?
#86: FILE: drivers/gpu/drm/i915/display/intel_display.h:195:
+#define for_each_dbuf_slice_in_mask(__dev_priv, __slice, __mask) \
+	for_each_dbuf_slice((__dev_priv), (__slice)) \
+		for_each_if((__mask) & BIT(__slice))

total: 1 errors, 0 warnings, 2 checks, 162 lines checked
b571b996abd4 drm/i915: Add enabledisable()
bb42f353dfe4 drm/i915: Say "enable foo" instead of "set foo to enabled"




More information about the Intel-gfx mailing list