[Intel-gfx] [PATCH 20/57] drm/i915: Wrap access to intel_engine.active

[Chris Wilson]

Quoting Chris Wilson (2021-02-04 11:18:29)
> Quoting Tvrtko Ursulin (2021-02-04 11:07:07)
> > 
> > 
> > On 01/02/2021 08:56, Chris Wilson wrote:
> > > diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
> > > index b56e321ef003..280d84c4e4b7 100644
> > > --- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
> > > +++ b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
> > > @@ -293,6 +293,7 @@ static int virtual_prio(const struct intel_engine_execlists *el)
> > >   static bool need_preempt(const struct intel_engine_cs *engine,
> > >                        const struct i915_request *rq)
> > >   {
> > > +     const struct i915_sched *se = &engine->active;
> > 
> > There's only two instances in this patch which do not use 
> > intel_engine_get_scheduler. Intended?
> 
> They were the ones I earmarked for being replaced by the scheduler
> object being passed down. Having down that I can do the replacement here
> and remove the conflicts with the final result later.

The catch here was the const. We can't make the getter take a const*
at this point, so I left it as &engine->active to not have to remove the
constness.
-Chris