[Intel-gfx] [PATCH 0/5] Split GuC submission from execlists submission

Daniele Ceraolo Spurio daniele.ceraolospurio at intel.com
Tue Jan 5 23:19:42 UTC 2021


Now that we have a common set of function for general lrc management,
the only remaining dependency the guc submission code has towards the
execlists submission is the engine setup. This series gets rid of that
by copying the required execlists setup function in the GuC submission
file; the copied functions have been further simplified by removing all
the parts that are specific to the execlists submission back-end.

To make the work easier, a bunch of GuC code that is not applicable to
the latest GuC submission flow (which should be posted soon-ish) is
removed as part of the series.

While doing this split I've noticed that it is not very clear which
settings belong in the engine setup and which ones in the
set_default_submission() call. I believe most of it can be moved from
the latter to the former, but, given that this impacts the execlists
backend as well, I plan to tackle it separately.

Cc: John Harrison <John.C.Harrison at Intel.com>
Cc: Matthew Brost <matthew.brost at intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
Cc: Chris Wilson <chris at chris-wilson.co.uk>

Daniele Ceraolo Spurio (4):
  drm/i915/guc: do not dump execlists state with GuC submission
  drm/i915/guc: init engine directly in GuC submission mode
  drm/i915/guc: stop calling execlists_set_default_submission
  drm/i915/guc: enable only the user interrupt when using GuC submission

Matthew Brost (1):
  drm/i915/guc: Delete GuC code unused in future patches

 drivers/gpu/drm/i915/gt/intel_engine_cs.c     |   9 +-
 .../drm/i915/gt/intel_execlists_submission.c  |   6 +-
 .../drm/i915/gt/intel_execlists_submission.h  |   2 -
 drivers/gpu/drm/i915/gt/intel_gt_irq.c        |  18 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc.c        |  16 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc.h        |   7 -
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 477 ++++++++++--------
 .../gpu/drm/i915/gt/uc/intel_guc_submission.h |   1 +
 8 files changed, 291 insertions(+), 245 deletions(-)

-- 
2.29.2



More information about the Intel-gfx mailing list