[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: split out new intel_backlight.[ch]

Patchwork patchwork at emeril.freedesktop.org
Wed May 12 13:58:25 UTC 2021


== Series Details ==

Series: drm/i915: split out new intel_backlight.[ch]
URL   : https://patchwork.freedesktop.org/series/90078/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
5c56f5e2aca2 drm/i915/backlight: extract backlight code to a separate file
-:57: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#57: 
new file mode 100644

-:262: WARNING:LINE_SPACING: Missing a blank line after declarations
#262: FILE: drivers/gpu/drm/i915/display/intel_backlight.c:201:
+	u32 val = intel_de_read(dev_priv, BLC_PWM_PCH_CTL2) & ~BACKLIGHT_DUTY_CYCLE_MASK;
+	intel_de_write(dev_priv, BLC_PWM_PCH_CTL2, val | level);

-:1822: WARNING:BRACES: braces {} are not necessary for any arm of this statement
#1822: FILE: drivers/gpu/drm/i915/display/intel_backlight.c:1761:
+		if (connector->base.connector_type == DRM_MODE_CONNECTOR_DSI) {
[...]
+		} else {
[...]

-:1891: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#1891: FILE: drivers/gpu/drm/i915/display/intel_backlight.h:46:
+}
+static inline void intel_backlight_device_unregister(struct intel_connector *connector)

total: 0 errors, 3 warnings, 1 checks, 3769 lines checked
019319571e81 drm/i915/backlight: mass rename functions to have intel_backlight_ prefix
-:557: WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#557: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:239:
+	panel->backlight.pwm_funcs->disable(conn_state, intel_backlight_invert_pwm_level(connector, 0));

total: 0 errors, 1 warnings, 0 checks, 568 lines checked
edb31254e71a drm/i915/panel: mass rename functions to have intel_panel_ prefix




More information about the Intel-gfx mailing list