[Intel-gfx] [PATCH] drm/i915: nuke local versions of WARN_ON/WARN_ON_ONCE

Lucas De Marchi lucas.demarchi at intel.com
Sat Jan 22 00:42:59 UTC 2022


On Fri, Jan 21, 2022 at 03:29:57PM +0200, Jani Nikula wrote:
>In general, we should avoid redefining kernel macros like this. It can
>get confusing, and what gets used will depend on whether the header is
>included or not. Moreover, we should prefer drm_WARN_ON() and
>drm_WARN_ON_ONCE() anyway, which include the stringified error condition
>in the message.
>
>Signed-off-by: Jani Nikula <jani.nikula at intel.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>


Lucas De Marchi


More information about the Intel-gfx mailing list