[Intel-gfx] [PATCH] drm/i915: nuke local versions of WARN_ON/WARN_ON_ONCE
Jani Nikula
jani.nikula at intel.com
Mon Jan 24 12:33:52 UTC 2022
On Fri, 21 Jan 2022, Lucas De Marchi <lucas.demarchi at intel.com> wrote:
> On Fri, Jan 21, 2022 at 03:29:57PM +0200, Jani Nikula wrote:
>>In general, we should avoid redefining kernel macros like this. It can
>>get confusing, and what gets used will depend on whether the header is
>>included or not. Moreover, we should prefer drm_WARN_ON() and
>>drm_WARN_ON_ONCE() anyway, which include the stringified error condition
>>in the message.
>>
>>Signed-off-by: Jani Nikula <jani.nikula at intel.com>
>
>
> Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>
Thanks, pushed to drm-intel-next.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
More information about the Intel-gfx
mailing list