[Intel-gfx] [PATCH 00/16] drm/i915: stop modifying "const" device info

Jani Nikula jani.nikula at intel.com
Mon Jun 20 08:37:59 UTC 2022


Move any device info that gets modified runtime into runtime info,
making device info a const pointer. Finally throw mkwrite_device_info()
into the curb.

The data size increases by sizeof(struct intel_runtime_info) for each
struct intel_device_info in i915_pci.c.

bloat-o-meter gives chg +0.08% in text size, almost all of which is
caused by the last commit (drm/i915: make device info a pointer to
static const data). IMO the first 14-15 commits separating
static/runtime info are worth it even if we decide the text size penalty
is too much to switch to using a pointer for static device info.

BR,
Jani.


Jani Nikula (16):
  drm/i915: use GRAPHICS_VER() instead of accessing match_info directly
  drm/i915: combine device info printing into one
  drm/i915: add initial runtime info into device info
  drm/i915: move fbc_mask to runtime info
  drm/i915: move page_sizes to runtime info
  drm/i915: move ppgtt_type and ppgtt_size to runtime info
  drm/i915: move has_pooled_eu to runtime info
  drm/i915: move memory_regions to runtime info
  drm/i915: move platform_engine_mask to runtime info
  drm/i915: move graphics.ver and graphics.rel to runtime info
  drm/i915: move pipe_mask and cpu_transcoder_mask to runtime info
  drm/i915: move has_hdcp to runtime info
  drm/i915: move has_dmc to runtime info
  drm/i915: move has_dsc to runtime info
  drm/i915: stop resetting display info to zero for no display
  drm/i915: make device info a pointer to static const data

 drivers/gpu/drm/i915/display/intel_display.h  |   4 +-
 drivers/gpu/drm/i915/display/intel_fbc.c      |   6 +-
 drivers/gpu/drm/i915/display/intel_hdcp.c     |   4 +-
 drivers/gpu/drm/i915/display/intel_vdsc.c     |   2 +-
 .../drm/i915/display/skl_universal_plane.c    |   2 +-
 drivers/gpu/drm/i915/gem/i915_gem_pages.c     |   2 +-
 .../gpu/drm/i915/gem/selftests/huge_pages.c   |  18 +-
 drivers/gpu/drm/i915/gt/intel_engine_cs.c     |   2 +-
 drivers/gpu/drm/i915/gt/intel_ppgtt.c         |   2 +-
 drivers/gpu/drm/i915/gt/intel_sseu.c          |   5 +-
 drivers/gpu/drm/i915/i915_debugfs.c           |   3 +-
 drivers/gpu/drm/i915/i915_driver.c            |  23 +-
 drivers/gpu/drm/i915/i915_drv.h               |  35 ++-
 drivers/gpu/drm/i915/i915_gem.c               |   3 +-
 drivers/gpu/drm/i915/i915_gpu_error.c         |   3 +-
 drivers/gpu/drm/i915/i915_pci.c               | 230 +++++++++---------
 drivers/gpu/drm/i915/intel_device_info.c      |  73 +++---
 drivers/gpu/drm/i915/intel_device_info.h      |  82 ++++---
 drivers/gpu/drm/i915/intel_uncore.c           |   2 +-
 .../gpu/drm/i915/selftests/mock_gem_device.c  |   8 +-
 20 files changed, 255 insertions(+), 254 deletions(-)

-- 
2.30.2



More information about the Intel-gfx mailing list