[Intel-gfx] [PATCH 01/15] drm/i915: Drop pointless middle man variable

[Jani Nikula]

On Mon, 26 Sep 2022, Luca Coelho <luca at coelho.fi> wrote:
> On Mon, 2022-09-12 at 14:18 +0300, Ville Syrjala wrote:
>> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>> 
>> No need for the 'procmon' variable here. Just return the correct
>> thing from the switch statement directly.
>> 
>> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
>> ---
>
> This doesn't make any difference in practice, the compiler will very 
> likely optimize out the procmon variable.
>
> In general, I think I think it's preferable to avoid this kind of
> patches, because they just make git blame a bit harder to interpret.

I think it's nicer to read, ymmv.

>
> Nevertheless, this is certainly not a reason to nack, so:
>
> Reviewed-by: Luca Coelho <luciano.coelho at intel.com>

N.b. I've already reviewed patches 1-13. [1]

BR,
Jani.

[1] https://lore.kernel.org/r/87fsgw6bs3.fsf@intel.com

>
> --
> Cheers,
> Luca.
>

-- 
Jani Nikula, Intel Open Source Graphics Center