[Intel-gfx] [PATCH 01/15] drm/i915: Drop pointless middle man variable

Luca Coelho luca at coelho.fi
Mon Sep 26 10:33:52 UTC 2022


On Mon, 2022-09-12 at 14:18 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> No need for the 'procmon' variable here. Just return the correct
> thing from the switch statement directly.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---

This doesn't make any difference in practice, the compiler will very 
likely optimize out the procmon variable.

In general, I think I think it's preferable to avoid this kind of
patches, because they just make git blame a bit harder to interpret.

Nevertheless, this is certainly not a reason to nack, so:

Reviewed-by: Luca Coelho <luciano.coelho at intel.com>

--
Cheers,
Luca.



More information about the Intel-gfx mailing list