[Intel-gfx] [PATCH v6 7/8] drm/i915/pxp: On MTL, KCR enabling doesn't wait on tee component

[Teres Alexis, Alan Previn]

> 
alan:snip
> > @@ -140,10 +141,15 @@ static void pxp_init_full(struct intel_pxp *pxp)
> >   	if (ret)
> >   		return;
> >   
> > -	if (HAS_ENGINE(pxp->ctrl_gt, GSC0))
> > +	if (HAS_ENGINE(pxp->ctrl_gt, GSC0)) {
> >   		ret = intel_pxp_gsccs_init(pxp);
> > -	else
> > +		if (!ret) {
> > +			with_intel_runtime_pm(&pxp->ctrl_gt->i915->runtime_pm, wakeref)
> > +				intel_pxp_init_hw(pxp);
> 
> personal preference: I'd move this (and the matching call in fini) 
> inside intel_pxp_gsccs_init/fini. That way we can see this as more 
> back-end specific: the gsccs initialize everything immediately, while 
> the tee back-end follows a 2-step approach with the component.
> Not a blocker since it is a personal preference, so with or without the 
> change:
> 
> Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> 
> Daniele

alan: will make that change too - thanks for the R-b.
alan:snip