[Intel-gfx] [PATCH v6 6/8] drm/i915/pxp: MTL-KCR interrupt ctrl's are in GT-0

[Teres Alexis, Alan Previn]

> 
alan:snip

> >   void intel_pxp_irq_enable(struct intel_pxp *pxp)
> >   {
> > -	struct intel_gt *gt = pxp->ctrl_gt;
> > +	struct intel_gt *gt = intel_pxp_get_irq_gt(pxp);
> 
> in this function we use the gt for:
> 
> 1 - the lock: see above about this
> 
> 2 - gen11_gt_reset_one_iir(): this should work with the media GT (we use 
> it for media GuC)
> 
> 3 - writes to the GEN11_CRYPTO_* regs: those should also work with the 
> media GT uncore as these regs are in the same range as the GuC scratch 
> regs and we use the media uncore for those accesses.
> 
alan:snip
> > @@ -83,7 +101,7 @@ void intel_pxp_irq_enable(struct intel_pxp *pxp)
> >   
> >   void intel_pxp_irq_disable(struct intel_pxp *pxp)
> >   {
> > -	struct intel_gt *gt = pxp->ctrl_gt;
> > +	struct intel_gt *gt = intel_pxp_get_irq_gt(pxp);
> >   
> 
> AFAICS this functions uses the same 3 cases as above.
> 
> Overall, I am not sure this patch is required. Am I missing something?
> 
alan: context: during development of my initial few revs, i needed to
explicitly do that switch-over to the other gt in order to even get the IRQs.
(i.e. as if the forcewake didnt wake up the range)... but upon recent
retesting it seems to work fine. I guess there must have been a bug
somewhere else in my branch.
So yes i believe this means we can totally remove this patch