[Intel-gfx] [PATCH] drm/i915/gt: Use i915 instead of dev_priv as name for the private device

Andi Shyti andi.shyti at linux.intel.com
Tue Feb 14 10:39:35 UTC 2023


Hi,

On Mon, Feb 13, 2023 at 03:36:54PM -0800, Lucas De Marchi wrote:
> On Mon, Feb 13, 2023 at 02:11:26PM +0100, Das, Nirmoy wrote:
> > 
> > On 2/10/2023 4:03 PM, Andi Shyti wrote:
> > > It is becoming a strong habit to call the drm_i915_private
> > > structures "i915", but there are still many left that are called
> > > dev_priv.
> > > 
> > > Sometimes this makes grepping a bit challenging and anyway it
> > > keeps a coherent style.
> > > 
> > > Rename all the "dev_priv" structures in the gt/* directory to
> > > "i915".
> > > 
> > > Signed-off-by: Andi Shyti <andi.shyti at linux.intel.com>
> > > ---
> > > Hi,
> > > 
> > > just checking if we want something similar. I have this same
> > > replicated patch for the rest of i915 but I want to make sure we
> > > actually want it.

Thanks Nirmoy for the review!

> > I might be lacking historical context here but I assumption is we are
> > moving towards replacing dev_priv with i915 everywhere.
> 
> Context: 20230201135329.514677-1-luciano.coelho at intel.com and 87bkml5wv4.fsf at intel.com

I think I have everything fixed, just didn't have time to format
patches correctly. So that I decided to take this baby step
to test the ground first and then move forward in the next couple
of weeks.

I don't think this patch that affects only the content of "gt/"
has any dependency on dev_priv macros so that please let me know
if anyone has anything against.

Thanks,
Andi


More information about the Intel-gfx mailing list